You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "aaron-ai (via GitHub)" <gi...@apache.org> on 2023/06/14 09:30:52 UTC
[GitHub] [rocketmq-clients] aaron-ai opened a new pull request, #547: Implement the reentrant PushConsumer message receiving
aaron-ai opened a new pull request, #547:
URL: https://github.com/apache/rocketmq-clients/pull/547
<!-- Please make sure the target branch is right. In most case, the target branch should be `master`. -->
### Which Issue(s) This PR Fixes
<!-- Please ensure that the related issue has already been created, and [link this pull request to that issue using keywords](<https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword>) to ensure automatic closure. -->
Fixes #525
### Brief Description
<!-- Write a brief description for your pull request to help the maintainer understand the reasons behind your changes. -->
Set the `attempt_id` for `ReceiveMessageRequest` of the push consumer, and reuse the last `attempt_id` when the request times out.
### How Did You Test This Change?
<!-- In order to ensure the code quality of Apache RocketMQ, we expect every pull request to have undergone thorough testing. -->
By unit testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-clients] aaron-ai merged pull request #547: Implement the reentrant PushConsumer message receiving
Posted by "aaron-ai (via GitHub)" <gi...@apache.org>.
aaron-ai merged PR #547:
URL: https://github.com/apache/rocketmq-clients/pull/547
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-clients] codecov-commenter commented on pull request #547: Implement the reentrant PushConsumer message receiving
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #547:
URL: https://github.com/apache/rocketmq-clients/pull/547#issuecomment-1590845675
## [Codecov](https://app.codecov.io/gh/apache/rocketmq-clients/pull/547?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#547](https://app.codecov.io/gh/apache/rocketmq-clients/pull/547?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (edcd7f9) into [master](https://app.codecov.io/gh/apache/rocketmq-clients/commit/1ccf99ca3d2ca55649c0a8a3ab8089d910568ba4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (1ccf99c) will **decrease** coverage by `0.01%`.
> The diff coverage is `52.63%`.
```diff
@@ Coverage Diff @@
## master #547 +/- ##
============================================
- Coverage 45.83% 45.83% -0.01%
- Complexity 659 662 +3
============================================
Files 207 207
Lines 11491 11501 +10
Branches 2931 2933 +2
============================================
+ Hits 5267 5271 +4
- Misses 5996 6001 +5
- Partials 228 229 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| java | `62.59% <52.63%> (-0.07%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/rocketmq-clients/pull/547?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...cketmq/client/java/impl/consumer/ConsumerImpl.java](https://app.codecov.io/gh/apache/rocketmq-clients/pull/547?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-amF2YS9jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL2NsaWVudC9qYXZhL2ltcGwvY29uc3VtZXIvQ29uc3VtZXJJbXBsLmphdmE=) | `72.50% <50.00%> (-0.61%)` | :arrow_down: |
| [...mq/client/java/impl/consumer/ProcessQueueImpl.java](https://app.codecov.io/gh/apache/rocketmq-clients/pull/547?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-amF2YS9jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL2NsaWVudC9qYXZhL2ltcGwvY29uc3VtZXIvUHJvY2Vzc1F1ZXVlSW1wbC5qYXZh) | `65.80% <52.94%> (-0.57%)` | :arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org