You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "Stamatis Zampetakis (Jira)" <ji...@apache.org> on 2020/08/06 13:14:00 UTC

[jira] [Updated] (HIVE-23934) Refactor TezCompiler#markSemiJoinForDPP to avoid redundant operations in nested while

     [ https://issues.apache.org/jira/browse/HIVE-23934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stamatis Zampetakis updated HIVE-23934:
---------------------------------------
    Description: 
Most of the code inside the nested while loop can be extracted and computed only once in the external loop. Moreover there are catch clauses for NPE which seem rather predictable and could possibly be avoided by proper checks.  

In addition the code should be adapted to handle the case of multi column semijoin reducers 

The goal of this issue is to refactor TezCompiler#markSemiJoinForDPP method to avoid redundant operations and improve code readability. As a side effect of this refactoring the method will be slightly more efficient although unlikely to have observable difference in practice.

  was:
Most of the code inside the nested while loop can be extracted and computed only once in the external loop. Moreover there are catch clauses for NPE which seem rather predictable and could possibly be avoided by proper checks.  

The goal of this issue is to refactor TezCompiler#markSemiJoinForDPP method to avoid redundant operations and improve code readability. As a side effect of this refactoring the method will be slightly more efficient although unlikely to have observable difference in practice.


> Refactor TezCompiler#markSemiJoinForDPP to avoid redundant operations in nested while
> -------------------------------------------------------------------------------------
>
>                 Key: HIVE-23934
>                 URL: https://issues.apache.org/jira/browse/HIVE-23934
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Stamatis Zampetakis
>            Assignee: Stamatis Zampetakis
>            Priority: Minor
>
> Most of the code inside the nested while loop can be extracted and computed only once in the external loop. Moreover there are catch clauses for NPE which seem rather predictable and could possibly be avoided by proper checks.  
> In addition the code should be adapted to handle the case of multi column semijoin reducers 
> The goal of this issue is to refactor TezCompiler#markSemiJoinForDPP method to avoid redundant operations and improve code readability. As a side effect of this refactoring the method will be slightly more efficient although unlikely to have observable difference in practice.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)