You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flume.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/11/22 17:44:00 UTC
[jira] [Commented] (FLUME-3294) Fix polling logic in TaildirSource
[ https://issues.apache.org/jira/browse/FLUME-3294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16696157#comment-16696157 ]
ASF GitHub Bot commented on FLUME-3294:
---------------------------------------
GitHub user turcsanyip opened a pull request:
https://github.com/apache/flume/pull/241
FLUME-3294 Fix polling logic in TaildirSource
TaildirSource.process() implements the correct polling logic now. It returns
Status.READY / Status.BACKOFF which controls the common backoff sleeping
mechanism implemented in PollableSourceRunner.PollingRunner (instead of
always returning Status.READY and sleeping inside the method which was
an incorrect behaviour).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/turcsanyip/flume FLUME-3294
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flume/pull/241.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #241
----
commit adf44790848b371fcf39aa8a8917a7d9cd5bb66e
Author: turcsanyi <tu...@...>
Date: 2018-11-22T12:43:39Z
FLUME-3294 Fix polling logic in TaildirSource
TaildirSource.process() implements the correct polling logic now. It returns
Status.READY / Status.BACKOFF which controls the common backoff sleeping
mechanism implemented in PollableSourceRunner.PollingRunner (instead of
always returning Status.READY and sleeping inside the method which was
an incorrect behaviour).
----
> Fix polling logic in TaildirSource
> ----------------------------------
>
> Key: FLUME-3294
> URL: https://issues.apache.org/jira/browse/FLUME-3294
> Project: Flume
> Issue Type: Bug
> Affects Versions: 1.8.0
> Reporter: Peter Turcsanyi
> Assignee: Peter Turcsanyi
> Priority: Major
> Fix For: 1.9.0
>
>
> {{TaildirSource.process()}} always returns {{Status.READY}} and sleeps inside the method.
> It should return {{Status.READY}} / {{Status.BACKOFF}} and this status would control the common backoff sleeping mechanism implemented in {{PollableSourceRunner.PollingRunner}}.
> This is an old issue, but due to the changes implemented in FLUME-3101, it can lead to unnecessary waiting cycles. So it must be fixed now.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@flume.apache.org
For additional commands, e-mail: issues-help@flume.apache.org