You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2018/11/29 18:00:28 UTC
[GitHub] rawlinp opened a new pull request #3066: Fix ordering of DS
matchlists to match the Perl
rawlinp opened a new pull request #3066: Fix ordering of DS matchlists to match the Perl
URL: https://github.com/apache/trafficcontrol/pull/3066
#### What does this PR do?
The DS matchlist needs to be ordered by the set_number just like it was
done in the Perl. There are clients that depend on that specific
ordering. For example, Traffic Portal uses the first exampleURL to create
the hostName field of an "add cert to DS" request. Since the exampleURLs
are created from the DS's matchlist, this can cause the cert request to
contain an alias which makes ORT unhappy.
#### Which TC components are affected by this PR?
- [ ] Documentation
- [ ] Grove
- [ ] Traffic Analytics
- [ ] Traffic Monitor
- [x] Traffic Ops
- [ ] Traffic Ops ORT
- [ ] Traffic Portal
- [ ] Traffic Router
- [ ] Traffic Stats
- [ ] Traffic Vault
- [ ] Other _________
#### What is the best way to verify this PR?
Run the unit tests, make sure they pass.
Create a DSes of type HTTP and DNS and add HOST_REGEXP aliases to them. Verify that the `<routing_name>.<xml_id>.<cdn_domain>` fqdn(s) are at the top of the list of the DS's example URLs.
#### Check all that apply
- [x] This PR includes tests
- [ ] This PR includes documentation updates
- [ ] This PR includes an update to CHANGELOG.md
- [ ] This PR includes all required license headers
- [ ] This PR includes a database migration (ensure that migration sequence is correct)
- [ ] This PR fixes a serious security flaw. Read more: [www.apache.org/security](http://www.apache.org/security/)
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services