[GitHub] [incubator-hudi] bvaradar commented on a change in pull request #722: HUDI-148 Small File selection logic for MOR must skip fileIds selected for pending compaction correctly

[GitBox <gi...@apache.org>]

bvaradar commented on a change in pull request #722: HUDI-148 Small File selection logic for MOR must skip fileIds selected for pending compaction correctly
URL: https://github.com/apache/incubator-hudi/pull/722#discussion_r291847352
 
 

 ##########
 File path: hoodie-client/src/main/java/com/uber/hoodie/table/HoodieMergeOnReadTable.java
 ##########
 @@ -394,7 +394,7 @@ protected HoodieRollingStatMetadata getRollingStats() {
         } else {
           // If we can index log files, we can add more inserts to log files.
           List<FileSlice> allFileSlices = getRTFileSystemView()
-              .getLatestFileSlicesBeforeOrOn(partitionPath, latestCommitTime.getTimestamp())
+              .getLatestFileSlicesBeforeOrOn(partitionPath, latestCommitTime.getTimestamp(), false)
 
 Review comment:
   With indexable log files, it is safe to route inserts to fileIds in compaction. This should be true. Will change it

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services