You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/06/18 14:35:26 UTC
[GitHub] [flink] azagrebin commented on a change in pull request #8778:
[FLINK-12615][coordination] Track partitions on JM
azagrebin commented on a change in pull request #8778: [FLINK-12615][coordination] Track partitions on JM
URL: https://github.com/apache/flink/pull/8778#discussion_r294857180
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java
##########
@@ -1061,6 +1063,20 @@ void markFinished(Map<String, Accumulator<?, ?>> userAccumulators, IOMetrics met
IntermediateResultPartition[] allPartitions = finishedPartition
.getIntermediateResult().getPartitions();
+ PartitionTable<ResourceID> partitionTable = vertex.getExecutionGraph().getPartitionTable();
Review comment:
We could consider introducing a separate component something like `PartitionTracker` which would also encapsulate `ShuffleMaster` (like `JobAwareShuffleEnvironmentImpl`). It could be responsible for doing what we have in this PR and maybe even register with the `ShuffleMaster` and track `producedPartitions` by execution id as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services