You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2021/01/29 23:43:00 UTC

[jira] [Commented] (GEODE-8898) Redis: HMgetDUnitTest does not run anything

    [ https://issues.apache.org/jira/browse/GEODE-8898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17275428#comment-17275428 ] 

ASF GitHub Bot commented on GEODE-8898:
---------------------------------------

nonbinaryprogrammer opened a new pull request #5981:
URL: https://github.com/apache/geode/pull/5981


   previously the threads were not being run. this runs them and adds an
   assertion that the fields and values are correct at the end of the test.
   
   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
   
   - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   - [ ] Does `gradlew build` run cleanly?
   
   - [ ] Have you written or updated unit tests to verify your changes?
   
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, check Concourse for build issues and
   submit an update to your PR as soon as possible. If you need help, please send an
   email to dev@geode.apache.org.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Redis: HMgetDUnitTest does not run anything
> -------------------------------------------
>
>                 Key: GEODE-8898
>                 URL: https://issues.apache.org/jira/browse/GEODE-8898
>             Project: Geode
>          Issue Type: Test
>          Components: redis
>            Reporter: Hale Bales
>            Priority: Major
>
> HMgetDUnitTest sets up some ConcurrentLoopingThreads but does not run them. add .run() and look for race conditions.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)