[GitHub] [accumulo] ctubbsii edited a comment on pull request #2007: Set reuseForks to true for unit tests, false for ITs

[GitBox <gi...@apache.org>]

ctubbsii edited a comment on pull request #2007:
URL: https://github.com/apache/accumulo/pull/2007#issuecomment-816873506


   @Manno15 This change actually broke the build. The exclude/include strategy won't work without renaming the tests or relocating the package they are in, because the maven-failsafe-plugin cannot load test classes from test jars that exist in the same package as classes loaded from the non-test jars, due to jar sealing violations. Unit tests run by maven-surefire-plugin don't have this problem because it doesn't load classes from jars, but from the `target/classes` directory (since it runs before the jars are built at the `package` phase).
   
   See https://docs.oracle.com/javase/tutorial/deployment/jar/sealman.html for more info about jar sealing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org