[jira] [Commented] (BEAM-13665) Spanner IO request metrics requires projectId within the config when it didn't in the past

["Ahmet Altay (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-13665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17476309#comment-17476309 ] 

Ahmet Altay commented on BEAM-13665:
------------------------------------

[~chamikara] [~kerrydc] - This is a backward incompatibility. Should this be a higher priority and block the next release?

> Spanner IO request metrics requires projectId within the config when it didn't in the past
> ------------------------------------------------------------------------------------------
>
>                 Key: BEAM-13665
>                 URL: https://issues.apache.org/jira/browse/BEAM-13665
>             Project: Beam
>          Issue Type: Bug
>          Components: io-java-gcp
>            Reporter: Luke Cwik
>            Priority: P2
>             Fix For: 2.36.0
>
>
> https://github.com/apache/beam/pull/15493 makes the GCP projectID a required parameter - which it was not before, as it could be inferred from the environment - and thus breaks backward compatibility.
> Specifically: BatchSpannerRead.java:175 -- the toString() is not required on the valueProvider, it should just be a get(), and createServiceCallMetric() in line 195 should handle the situation where projectID could be null



--
This message was sent by Atlassian Jira
(v8.20.1#820001)