You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@linkis.apache.org by GitBox <gi...@apache.org> on 2021/11/16 02:33:04 UTC
[GitHub] [incubator-linkis] lunescode opened a new pull request #1093: Dev 1.0.3 bugfix passauthuri add judgement of whether it is empty
lunescode opened a new pull request #1093:
URL: https://github.com/apache/incubator-linkis/pull/1093
### What is the purpose of the change
bugfix:
if the pass auth url set value “”, the method ".getRequestURI.startsWith" will always return true, it is not the result that we wanted, it can be a security risk.
### Brief change log
(for example:)
- Add judgement of whether it is empty
### Verifying this change
This change added tests and can be verified as follows:
- 1. set wds.linkis.gateway.conf.url.pass.auth="" in linkis-mg-gateway.properties, the restart gateway.
- 2. set wds.linkis.server.user.restful.uri.pass.auth="" in linkis-ps-publicservice.properties, the restart publicservice.
- 3. curl http://${gateway}/api/rest_j/v1/configuration/getCategory, if return "need login in" will be right.
### Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): ( no)
- Anything that affects deployment: ( no )
- The MGS(Microservice Governance Services), i.e., Spring Cloud Gateway, OpenFeign, Eureka.: (no)
### Documentation
- Does this pull request introduce a new feature? ( no)
- If yes, how is the feature documented? (not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org
For additional commands, e-mail: dev-help@linkis.apache.org
[GitHub] [incubator-linkis] peacewong merged pull request #1093: Dev 1.0.3 bugfix passauthuri add judgement of whether it is empty
Posted by GitBox <gi...@apache.org>.
peacewong merged pull request #1093:
URL: https://github.com/apache/incubator-linkis/pull/1093
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org
For additional commands, e-mail: dev-help@linkis.apache.org