You are viewing a plain text version of this content. The canonical link for it is here.

Posted to pr@jena.apache.org by GitBox <gi...@apache.org> on 2021/04/13 08:44:40 UTC

[GitHub] [jena] rvesse commented on a change in pull request #983: JENA-2086: No need to reset the journal every transaction.

rvesse commented on a change in pull request #983:
URL: https://github.com/apache/jena/pull/983#discussion_r612252393



##########
File path: jena-db/jena-dboe-transaction/src/main/java/org/apache/jena/dboe/transaction/txn/TransactionCoordinator.java
##########
@@ -705,12 +705,11 @@ private boolean promotionWaitForWriters() {
     /** Signal that the transaction has finished. */
     /*package*/ void completed(Transaction transaction) {
         finishActiveTransaction(transaction);
-        journal.reset();
         notifyEnd(transaction);

Review comment:
       I guess the above is the actual substantiative change in this PR. Any journal clean up actually happens elsewhere in abort/commit logic?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org