You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2022/11/11 03:31:37 UTC

[GitHub] [servicecomb-java-chassis] zzj8886 opened a new pull request, #3474: [SCB-2726] add TimeLimiter and Cache governance

zzj8886 opened a new pull request, #3474:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3474

   Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
    - [ ] Each commit in the pull request should have a meaningful subject line and body.
    - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
    - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [ ] Run `mvn clean install -Pit` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] liubao68 commented on a diff in pull request #3474: [SCB-2726] add TimeLimiter and Cache governance

Posted by GitBox <gi...@apache.org>.
liubao68 commented on code in PR #3474:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3474#discussion_r1019803493


##########
governance/src/test/java/org/apache/servicecomb/governance/GovernanceCacheHandlerTest.java:
##########
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.servicecomb.governance;
+
+
+import org.apache.servicecomb.governance.handler.GovernanceCacheHandler;
+import org.apache.servicecomb.governance.marker.GovernanceRequest;
+import org.apache.servicecomb.governance.policy.GovernanceCachePolicy;
+import org.apache.servicecomb.governance.service.GovernanceCache;
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.Test;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.boot.test.context.SpringBootTest;
+import org.springframework.test.context.ContextConfiguration;
+
+@SpringBootTest
+@ContextConfiguration(classes = {GovernanceConfiguration.class, MockConfiguration.class})
+public class GovernanceCacheHandlerTest {
+  private GovernanceCacheHandler<String, Object> governanceCacheHandler;
+
+  @Autowired
+  public void setInstanceIsolationHandler(@Autowired GovernanceCacheHandler<String, Object> governanceCacheHandler) {
+    this.governanceCacheHandler = governanceCacheHandler;
+  }
+
+  @Test
+  public void testMatchPriorityPolicy() {
+    GovernanceRequest request = new GovernanceRequest();
+    request.setUri("/governanceCache");
+    GovernanceCachePolicy policy = governanceCacheHandler.matchPolicy(request);
+    Assertions.assertEquals("demo-governanceCache", policy.getName());
+    GovernanceCache<String, Object> governanceCache = governanceCacheHandler.getActuator(request);
+    governanceCache.putValueIntoCache("governance", "Cache");
+    Object cache = governanceCache.getValueFromCache("governance");
+    Assertions.assertEquals("Cache", cache);

Review Comment:
   Add a test case for null value. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] liubao68 commented on a diff in pull request #3474: [SCB-2726] add TimeLimiter and Cache governance

Posted by GitBox <gi...@apache.org>.
liubao68 commented on code in PR #3474:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3474#discussion_r1019802000


##########
governance/src/main/java/org/apache/servicecomb/governance/policy/GovernanceCachePolicy.java:
##########
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.governance.policy;
+
+import java.time.Duration;
+
+public class GovernanceCachePolicy extends AbstractPolicy {
+    public static final Duration DEFAULT_TTL = Duration.ofMillis(21600000);
+
+    public static final Long DEFAULT_MAXIMUM_SIZE = 60000L;

Review Comment:
   can we use primitive type `long`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] liubao68 commented on a diff in pull request #3474: [SCB-2726] add TimeLimiter and Cache governance

Posted by GitBox <gi...@apache.org>.
liubao68 commented on code in PR #3474:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3474#discussion_r1019802782


##########
governance/src/main/java/org/apache/servicecomb/governance/service/GovernanceCacheImpl.java:
##########
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.governance.service;
+
+import com.google.common.cache.Cache;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class GovernanceCacheImpl<K, V> implements GovernanceCache<K, V> {
+
+  private static final Logger LOG = LoggerFactory.getLogger(GovernanceCacheImpl.class);
+
+  private final Cache<K, V> cache;
+
+  public GovernanceCacheImpl(Cache<K, V> cache) {
+    this.cache = cache;
+  }
+
+  public V getValueFromCache(K cacheKey) {
+    try {
+      return cache.getIfPresent(cacheKey);
+    } catch (Exception exception) {
+      LOG.warn("Failed to get a value from Cache", exception);
+      return null;
+    }
+  }
+
+  @Override
+  public void putValueIntoCache(K cacheKey, V value) {
+    try {
+      if (value != null) {
+        cache.put(cacheKey, value);
+      }
+    } catch (Exception exception) {
+      LOG.warn("Failed to put a value into Cache {}", exception);
+    }
+  }

Review Comment:
   Can cache value be `null`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] liubao68 commented on a diff in pull request #3474: [SCB-2726] add TimeLimiter and Cache governance

Posted by GitBox <gi...@apache.org>.
liubao68 commented on code in PR #3474:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3474#discussion_r1019801392


##########
governance/src/main/java/org/apache/servicecomb/governance/GovernanceConfiguration.java:
##########
@@ -161,6 +164,16 @@ public RetryHandler retryHandler(RetryProperties retryProperties, AbstractRetryE
     return new RetryHandler(retryProperties, retryExtension);
   }
 
+  @Bean
+  public TimeLimiterHandler timeLimiterHandler(TimeLimiterProperties timeLimiterProperties) {
+    return new TimeLimiterHandler(timeLimiterProperties);
+  }
+
+  @Bean
+  public GovernanceCacheHandler<String, Object> getResponseCacheHandler(GovernanceCacheProperties cacheProperties) {

Review Comment:
   bean name `governanceCacheHandler`  is better.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] liubao68 commented on a diff in pull request #3474: [SCB-2726] add TimeLimiter and Cache governance

Posted by GitBox <gi...@apache.org>.
liubao68 commented on code in PR #3474:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3474#discussion_r1019803493


##########
governance/src/test/java/org/apache/servicecomb/governance/GovernanceCacheHandlerTest.java:
##########
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.servicecomb.governance;
+
+
+import org.apache.servicecomb.governance.handler.GovernanceCacheHandler;
+import org.apache.servicecomb.governance.marker.GovernanceRequest;
+import org.apache.servicecomb.governance.policy.GovernanceCachePolicy;
+import org.apache.servicecomb.governance.service.GovernanceCache;
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.Test;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.boot.test.context.SpringBootTest;
+import org.springframework.test.context.ContextConfiguration;
+
+@SpringBootTest
+@ContextConfiguration(classes = {GovernanceConfiguration.class, MockConfiguration.class})
+public class GovernanceCacheHandlerTest {
+  private GovernanceCacheHandler<String, Object> governanceCacheHandler;
+
+  @Autowired
+  public void setInstanceIsolationHandler(@Autowired GovernanceCacheHandler<String, Object> governanceCacheHandler) {
+    this.governanceCacheHandler = governanceCacheHandler;
+  }
+
+  @Test
+  public void testMatchPriorityPolicy() {
+    GovernanceRequest request = new GovernanceRequest();
+    request.setUri("/governanceCache");
+    GovernanceCachePolicy policy = governanceCacheHandler.matchPolicy(request);
+    Assertions.assertEquals("demo-governanceCache", policy.getName());
+    GovernanceCache<String, Object> governanceCache = governanceCacheHandler.getActuator(request);
+    governanceCache.putValueIntoCache("governance", "Cache");
+    Object cache = governanceCache.getValueFromCache("governance");
+    Assertions.assertEquals("Cache", cache);

Review Comment:
   Add a test case for null value and key not present. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] liubao68 merged pull request #3474: [SCB-2726] add TimeLimiter and Cache governance

Posted by GitBox <gi...@apache.org>.
liubao68 merged PR #3474:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3474


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] liubao68 commented on a diff in pull request #3474: [SCB-2726] add TimeLimiter and Cache governance

Posted by GitBox <gi...@apache.org>.
liubao68 commented on code in PR #3474:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3474#discussion_r1019802098


##########
governance/src/main/java/org/apache/servicecomb/governance/policy/GovernanceCachePolicy.java:
##########
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.governance.policy;
+
+import java.time.Duration;
+
+public class GovernanceCachePolicy extends AbstractPolicy {
+    public static final Duration DEFAULT_TTL = Duration.ofMillis(21600000);
+
+    public static final Long DEFAULT_MAXIMUM_SIZE = 60000L;
+
+    public static final int DEFAULT_CONCURRENCY_LEVEL = 8;
+
+    private String ttl = DEFAULT_TTL.toString();
+
+    private Long maximumSize = DEFAULT_MAXIMUM_SIZE;

Review Comment:
   can we use primitive type `long`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] codecov-commenter commented on pull request #3474: [SCB-2726] add TimeLimiter and Cache governance

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #3474:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3474#issuecomment-1311386764

   # [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3474?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#3474](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3474?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7314204) into [master](https://codecov.io/gh/apache/servicecomb-java-chassis/commit/3cc794cdfa75a5a6583b4969bab994ef566de06b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3cc794c) will **increase** coverage by `0.04%`.
   > The diff coverage is `88.54%`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #3474      +/-   ##
   ============================================
   + Coverage     74.34%   74.38%   +0.04%     
     Complexity      667      667              
   ============================================
     Files          1580     1589       +9     
     Lines         39725    39821      +96     
     Branches       3632     3633       +1     
   ============================================
   + Hits          29532    29621      +89     
   - Misses         8712     8719       +7     
     Partials       1481     1481              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3474?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...vernance/properties/GovernanceCacheProperties.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3474/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z292ZXJuYW5jZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvZ292ZXJuYW5jZS9wcm9wZXJ0aWVzL0dvdmVybmFuY2VDYWNoZVByb3BlcnRpZXMuamF2YQ==) | `60.00% <60.00%> (ø)` | |
   | [...b/governance/properties/TimeLimiterProperties.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3474/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z292ZXJuYW5jZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvZ292ZXJuYW5jZS9wcm9wZXJ0aWVzL1RpbWVMaW1pdGVyUHJvcGVydGllcy5qYXZh) | `60.00% <60.00%> (ø)` | |
   | [...comb/governance/handler/DisposableTimeLimiter.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3474/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z292ZXJuYW5jZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvZ292ZXJuYW5jZS9oYW5kbGVyL0Rpc3Bvc2FibGVUaW1lTGltaXRlci5qYXZh) | `66.66% <66.66%> (ø)` | |
   | [...cecomb/governance/service/GovernanceCacheImpl.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3474/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z292ZXJuYW5jZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvZ292ZXJuYW5jZS9zZXJ2aWNlL0dvdmVybmFuY2VDYWNoZUltcGwuamF2YQ==) | `76.92% <76.92%> (ø)` | |
   | [...icecomb/governance/handler/TimeLimiterHandler.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3474/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z292ZXJuYW5jZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvZ292ZXJuYW5jZS9oYW5kbGVyL1RpbWVMaW1pdGVySGFuZGxlci5qYXZh) | `94.44% <94.44%> (ø)` | |
   | [...ervicecomb/governance/GovernanceConfiguration.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3474/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z292ZXJuYW5jZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvZ292ZXJuYW5jZS9Hb3Zlcm5hbmNlQ29uZmlndXJhdGlvbi5qYXZh) | `100.00% <100.00%> (ø)` | |
   | [...omb/governance/handler/GovernanceCacheHandler.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3474/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z292ZXJuYW5jZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvZ292ZXJuYW5jZS9oYW5kbGVyL0dvdmVybmFuY2VDYWNoZUhhbmRsZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
   | [...ecomb/governance/policy/GovernanceCachePolicy.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3474/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z292ZXJuYW5jZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvZ292ZXJuYW5jZS9wb2xpY3kvR292ZXJuYW5jZUNhY2hlUG9saWN5LmphdmE=) | `100.00% <100.00%> (ø)` | |
   | [...rvicecomb/governance/policy/TimeLimiterPolicy.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3474/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z292ZXJuYW5jZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvZ292ZXJuYW5jZS9wb2xpY3kvVGltZUxpbWl0ZXJQb2xpY3kuamF2YQ==) | `100.00% <100.00%> (ø)` | |
   | [...ervicecomb/governance/service/GovernanceCache.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3474/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z292ZXJuYW5jZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvZ292ZXJuYW5jZS9zZXJ2aWNlL0dvdmVybmFuY2VDYWNoZS5qYXZh) | `100.00% <100.00%> (ø)` | |
   | ... and [3 more](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3474/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org