You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/01/10 22:22:21 UTC

[GitHub] sandeep-krishnamurthy opened a new pull request #13837: Image ToTensor operator - GPU support, 3D/4D inputs

sandeep-krishnamurthy opened a new pull request #13837: Image ToTensor operator - GPU support, 3D/4D inputs
URL: https://github.com/apache/incubator-mxnet/pull/13837
 
 
   ## Description ##
   
   1. Make to_tensor as operator. No contribution to gradient.
   2. Support CPU and GPU. This PR adds GPU supports and re-organizes previously supported CPU.
   3. to_tensor transformation operator can take 3D (c, h, w) or 4D (n, c, h, w) at once. So that a batch of input can be passed in the transformation.
   4. Parallelization with OMP
   5. This is backward compatible change. No existing functionality will be affected.
   
   # Background 
   We can enable users to fuse transformation operators with network graph and export it. This end to end network with transforms + network will greatly simplify inference deployment.
   Related PR for normalize transformation - https://github.com/apache/incubator-mxnet/pull/13802/
   
   ## Checklist ##
   ### Essentials ###
   Please feel free to remove inapplicable items for your PR.
   - [X] Changes are complete (i.e. I finished coding on this PR)
   - [X] All changes have test coverage:
   - Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
   - [X] Code is well-documented: 
   - For user-facing API changes, API doc string has been updated. 
   - For new C++ functions in header files, their functionalities and arguments are documented. 
   - Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
   - [X] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
   
   ### Changes ###
   - Make to_tensor to accept 3D or 4D input
   - CPU / GPU support
   - No gradient contribution
   - Reorganize like any other operators
   
   ## Comments ##
   - A related PR was raised here https://github.com/apache/incubator-mxnet/pull/13614 reviewed by @apeforest and @stu1130 - I have addressed those comments. I am closing other PR as it was mixing multiple transforms and functionality.
   
   @apeforest @stu1130 @zhreshold @nswamy - For review
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services