You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2020/03/04 01:55:03 UTC

[GitHub] [kylin] hit-lacus commented on a change in pull request #1134: KYLIN-4396 Close FileReader in SaveDictStep

hit-lacus commented on a change in pull request #1134: KYLIN-4396 Close FileReader in SaveDictStep
URL: https://github.com/apache/kylin/pull/1134#discussion_r387407447
 
 

 ##########
 File path: engine-mr/src/main/java/org/apache/kylin/engine/mr/streaming/SaveDictStep.java
 ##########
 @@ -136,6 +136,7 @@ public boolean accept(Path path) {
                         logger.error("dictionary of column {} not found! ", colRef.getName());
                     }
                 }
+                reader.close();
 
 Review comment:
   Thank you!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services