You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/01/14 11:03:29 UTC
[GitHub] [netbeans] neilcsmith-net opened a new issue #3456: Ensure metabuild JSON is optional in source releases
neilcsmith-net opened a new issue #3456:
URL: https://github.com/apache/netbeans/issues/3456
### Body
The intention of having `netbeansrelease.properties` in source releases was so that building them is decoupled from the `metabuild.json` file. However the json parsing is still happening, and can overwrite the bundled information. Needs guarding.
cc / @ebarboni what are the json and xml files written to `nbbuild/build` used for? May affect where to fix this.
Opening as an issue so I can attach to milestone.
### Committer
- [X] I acknowledge that I am a maintainer/committer in the Apache NetBeans project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ebarboni commented on issue #3456: Ensure metabuild JSON is optional in source releases
Posted by GitBox <gi...@apache.org>.
ebarboni commented on issue #3456:
URL: https://github.com/apache/netbeans/issues/3456#issuecomment-1013051009
not sure if it related but #2421 may be triaged with that (potentially discarded)
xml file is for apidoc menu generation to get post/next apidoc to be parsed with xsl and so on.
json file was intended as cache
I think was I should have done is copy json + xml + properties in nbbuild and not nbuild/build. So we "lock what was used for build" and be sure we can rebuild offline from the "source package".
On jenkins it would'nt be present so will redownload each time.
On local build "master" or on "branch" it will no be updated except if we add a task to so or if we append ant clean maybe
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net closed issue #3456: Ensure metabuild JSON is optional in source releases
Posted by GitBox <gi...@apache.org>.
neilcsmith-net closed issue #3456:
URL: https://github.com/apache/netbeans/issues/3456
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on issue #3456: Ensure metabuild JSON is optional in source releases
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on issue #3456:
URL: https://github.com/apache/netbeans/issues/3456#issuecomment-1013061119
Thanks! Should have remembered that one. Potentially same solution for a slightly different problem. Yes, the important thing is to lock what was used in the build. Source bundle should build without downloading or being affected by online json file (unless specifying something like `-Dneedjsondownload`). Obviously fully offline depends on dependencies being available too.
Shall we link this to #2421 then and complete discussion there?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on issue #3456: Ensure metabuild JSON is optional in source releases
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on issue #3456:
URL: https://github.com/apache/netbeans/issues/3456#issuecomment-1022324320
So rc2 build with `ant build -Dmetabuild.jsonurl=https://netbeans.apache.org/foo.json` succeeds where same with rc1 fails.
Closing - GH doesn't appear to have picked up it's made its way to master now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists