You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "Abacn (via GitHub)" <gi...@apache.org> on 2025/04/24 21:18:44 UTC
[PR] [Do not merge] Parse struct returned from Dataflow API to BoundedTrieData [beam]
Abacn opened a new pull request, #34738:
URL: https://github.com/apache/beam/pull/34738
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Parse values returned from Dataflow API to BoundedTrieData [beam]
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on code in PR #34738:
URL: https://github.com/apache/beam/pull/34738#discussion_r2136353909
##########
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowMetrics.java:
##########
@@ -206,12 +210,21 @@ private StringSetResult getStringSetValue(MetricUpdate metricUpdate) {
}
private BoundedTrieResult getBoundedTrieValue(MetricUpdate metricUpdate) {
- if (metricUpdate.getTrie() == null) {
+ BoundedTrieData trieData = null;
+ Object trieFromResponse = metricUpdate.getBoundedTrie();
+ // Fail-safely cast Trie returned by dataflow API to BoundedTrieResult
+ if (trieFromResponse instanceof BoundedTrie) {
+ BoundedTrie bTrie = (BoundedTrie) metricUpdate.getBoundedTrie();
+ trieData = BoundedTrieData.fromProto(bTrie);
Review Comment:
Could this just be `trieData = BoundedTrieData.fromProto((BoundedTrie) trieFromResponse);`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Parse struct returned from Dataflow API to BoundedTrieData [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34738:
URL: https://github.com/apache/beam/pull/34738#issuecomment-2839765182
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Parse values returned from Dataflow API to BoundedTrieData [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #34738:
URL: https://github.com/apache/beam/pull/34738#issuecomment-2956905319
> Could you add some context on why we need this change/the Dataflow side changes enabling it? It generally seems fine, but I'm not sure why we need it
Thanks. Internal tracker is b/404336511. Basically
- Dataflow backend does not yet support returning BoundedTrie metrics
- When it supports, it will trigger a ClassCastException at https://github.com/apache/beam/blob/df54bf439b28b23c3380b913811633fd8678c403/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowMetrics.java#L212 because the returned type isn't BoundedTrie.
As a result a "boundedTrie" field is added in Dataflow v1beta3 proto, and properly handled by this PR (tested)
"trie" will remain empty and unused. So the Dataflow side rollout won't affect Beam 2.65 and earlier versions as we had similar issue (#32622) on Beam 2.58.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Parse values returned from Dataflow API to BoundedTrieData [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn merged PR #34738:
URL: https://github.com/apache/beam/pull/34738
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Parse values returned from Dataflow API to BoundedTrieData [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34738:
URL: https://github.com/apache/beam/pull/34738#issuecomment-2956473382
Assigning reviewers:
R: @damccorm for label build.
Note: If you would like to opt out of this review, comment `assign to next reviewer`.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Parse values returned from Dataflow API to BoundedTrieData [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on code in PR #34738:
URL: https://github.com/apache/beam/pull/34738#discussion_r2136724931
##########
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowMetrics.java:
##########
@@ -206,12 +210,21 @@ private StringSetResult getStringSetValue(MetricUpdate metricUpdate) {
}
private BoundedTrieResult getBoundedTrieValue(MetricUpdate metricUpdate) {
- if (metricUpdate.getTrie() == null) {
+ BoundedTrieData trieData = null;
+ Object trieFromResponse = metricUpdate.getBoundedTrie();
+ // Fail-safely cast Trie returned by dataflow API to BoundedTrieResult
+ if (trieFromResponse instanceof BoundedTrie) {
+ BoundedTrie bTrie = (BoundedTrie) metricUpdate.getBoundedTrie();
+ trieData = BoundedTrieData.fromProto(bTrie);
Review Comment:
Thanks for catching this. Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Parse values returned from Dataflow API to BoundedTrieData [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #34738:
URL: https://github.com/apache/beam/pull/34738#issuecomment-2960127960
beam_PreCommit_Java_Amazon-Web-Services2_IO_Direct flaky workflow not related to the change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org