You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/07/11 01:59:07 UTC
[GitHub] [doris] jacktengg opened a new pull request, #10745: [improvement] remove _free_blocks of VOlapScannode to simplify logic
jacktengg opened a new pull request, #10745:
URL: https://github.com/apache/doris/pull/10745
# Proposed changes
Issue Number: close #xxx
## Problem Summary:
Describe the overview of changes.
## Checklist(Required)
1. Does it affect the original behavior: (Yes/No/I Don't know)
2. Has unit tests been added: (Yes/No/No Need)
3. Has document been added or modified: (Yes/No/No Need)
4. Does it need to update dependencies: (Yes/No)
5. Are there any changes that cannot be rolled back: (Yes/No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] jacktengg closed pull request #10745: [improvement] remove _free_blocks of VOlapScannode to simplify logic
Posted by GitBox <gi...@apache.org>.
jacktengg closed pull request #10745: [improvement] remove _free_blocks of VOlapScannode to simplify logic
URL: https://github.com/apache/doris/pull/10745
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei commented on a diff in pull request #10745: [improvement] remove _free_blocks of VOlapScannode to simplify logic
Posted by GitBox <gi...@apache.org>.
yiguolei commented on code in PR #10745:
URL: https://github.com/apache/doris/pull/10745#discussion_r917521948
##########
be/src/vec/exec/volap_scan_node.cpp:
##########
@@ -42,19 +42,16 @@ VOlapScanNode::VOlapScanNode(ObjectPool* pool, const TPlanNode& tnode, const Des
_tuple_desc(nullptr),
_tuple_idx(0),
_eos(false),
- _max_materialized_row_batches(config::doris_scanner_queue_size),
_start(false),
_scanner_done(false),
_transfer_done(false),
_status(Status::OK()),
_resource_info(nullptr),
- _buffered_bytes(0),
_eval_conjuncts_fn(nullptr),
_runtime_filter_descs(tnode.runtime_filters),
_max_materialized_blocks(config::doris_scanner_queue_size),
_output_slot_ids(tnode.output_slot_ids) {
_materialized_blocks.reserve(_max_materialized_blocks);
Review Comment:
_max_materialized_blocks since it is always == config::doris_scanner_queue_size, we could remove this parameter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei commented on a diff in pull request #10745: [improvement] remove _free_blocks of VOlapScannode to simplify logic
Posted by GitBox <gi...@apache.org>.
yiguolei commented on code in PR #10745:
URL: https://github.com/apache/doris/pull/10745#discussion_r917522373
##########
be/src/vec/exec/volap_scan_node.cpp:
##########
@@ -518,32 +502,24 @@ void VOlapScanNode::scanner_thread(VOlapScanner* scanner) {
break;
}
- auto block = _alloc_block(get_free_block);
- status = scanner->get_block(_runtime_state, block, &eos);
+ auto block = std::make_unique<Block>(Block(_tuple_desc->slots(), _block_size));
Review Comment:
std::make_unique<Block>(_tuple_desc->slots(), _block_size);
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] jacktengg commented on a diff in pull request #10745: [improvement] remove _free_blocks of VOlapScannode to simplify logic
Posted by GitBox <gi...@apache.org>.
jacktengg commented on code in PR #10745:
URL: https://github.com/apache/doris/pull/10745#discussion_r917918822
##########
be/src/vec/exec/volap_scan_node.cpp:
##########
@@ -42,19 +42,16 @@ VOlapScanNode::VOlapScanNode(ObjectPool* pool, const TPlanNode& tnode, const Des
_tuple_desc(nullptr),
_tuple_idx(0),
_eos(false),
- _max_materialized_row_batches(config::doris_scanner_queue_size),
_start(false),
_scanner_done(false),
_transfer_done(false),
_status(Status::OK()),
_resource_info(nullptr),
- _buffered_bytes(0),
_eval_conjuncts_fn(nullptr),
_runtime_filter_descs(tnode.runtime_filters),
_max_materialized_blocks(config::doris_scanner_queue_size),
_output_slot_ids(tnode.output_slot_ids) {
_materialized_blocks.reserve(_max_materialized_blocks);
Review Comment:
fixed
##########
be/src/vec/exec/volap_scan_node.cpp:
##########
@@ -518,32 +502,24 @@ void VOlapScanNode::scanner_thread(VOlapScanner* scanner) {
break;
}
- auto block = _alloc_block(get_free_block);
- status = scanner->get_block(_runtime_state, block, &eos);
+ auto block = std::make_unique<Block>(Block(_tuple_desc->slots(), _block_size));
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] jacktengg commented on pull request #10745: [improvement] remove _free_blocks of VOlapScannode to simplify logic
Posted by GitBox <gi...@apache.org>.
jacktengg commented on PR #10745:
URL: https://github.com/apache/doris/pull/10745#issuecomment-1185083138
Performace test result is not good, close it for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org