You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "tisonkun (via GitHub)" <gi...@apache.org> on 2023/04/10 13:42:19 UTC

[GitHub] [pulsar-client-go] tisonkun opened a new pull request, #1007: ci: stablize golangci-lint task

tisonkun opened a new pull request, #1007:
URL: https://github.com/apache/pulsar-client-go/pull/1007

   This closes #1005.
   
   ### Modifications
   
   *Describe the modifications you've done.*
   
   ### Verifying this change
   
   - [x] Make sure that the change passes the CI checks.
   
   ### Documentation
   
     - Does this pull request introduce a new feature? (yes / no)
     - If yes, how is the feature documented? (not applicable / docs / GoDocs / not documented)
     - If a feature is not applicable for documentation, explain why?
     - If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar-client-go] tisonkun merged pull request #1007: ci: stablize golangci-lint task

Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun merged PR #1007:
URL: https://github.com/apache/pulsar-client-go/pull/1007


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar-client-go] Gleiphir2769 commented on pull request #1007: ci: stablize golangci-lint task

Posted by "Gleiphir2769 (via GitHub)" <gi...@apache.org>.
Gleiphir2769 commented on PR #1007:
URL: https://github.com/apache/pulsar-client-go/pull/1007#issuecomment-1502595019

   Good work! @tisonkun 
   
   But I am very curious why `httpclient` can pass the previous CI. It's introduced in 2021. It means the old golangci-lint we used has the ability for ignoring old files?
   
   I do not find any golangci-lint doc for this so I can not understand why this happens. This is so weird.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar-client-go] tisonkun commented on pull request #1007: ci: stablize golangci-lint task

Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #1007:
URL: https://github.com/apache/pulsar-client-go/pull/1007#issuecomment-1501962492

   Merging...
   
   Unblock other PRs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar-client-go] shibd commented on pull request #1007: ci: stablize golangci-lint task

Posted by "shibd (via GitHub)" <gi...@apache.org>.
shibd commented on PR #1007:
URL: https://github.com/apache/pulsar-client-go/pull/1007#issuecomment-1501891144

   @tisonkun Please help explain why?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar-client-go] tisonkun commented on pull request #1007: ci: stablize golangci-lint task

Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #1007:
URL: https://github.com/apache/pulsar-client-go/pull/1007#issuecomment-1501899693

   > why
   
   Why for what?
   
   You can refer to the issue for the failure. Generally, we use a `v3` tag for golangci-lint action which is not fixed. So anything can be changed from upstream. This patch pinned the golangci-lint to v1.51.2 and does not use the action to ignore any bad case there.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar-client-go] Gleiphir2769 commented on pull request #1007: ci: stablize golangci-lint task

Posted by "Gleiphir2769 (via GitHub)" <gi...@apache.org>.
Gleiphir2769 commented on PR #1007:
URL: https://github.com/apache/pulsar-client-go/pull/1007#issuecomment-1502611036

   > Besides, it's a false positive on bodyclose linter. There are a few false positive reports upstream, like [timakin/bodyclose#42](https://github.com/timakin/bodyclose/issues/42).
   
   I see. It's actually a false positive. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar-client-go] shibd commented on pull request #1007: ci: stablize golangci-lint task

Posted by "shibd (via GitHub)" <gi...@apache.org>.
shibd commented on PR #1007:
URL: https://github.com/apache/pulsar-client-go/pull/1007#issuecomment-1501916915

   > > why
   > 
   > Why for what?
   > 
   > You can refer to the issue for the failure. Generally, we use a `v3` tag for golangci-lint action which is not fixed. So anything can be changed from upstream. This patch pinned the golangci-lint to v1.51.2 and does not use the action to ignore any bad case there.
   
   FYI, we have fixed the version here.
   
   https://github.com/apache/pulsar-client-go/pull/951/files


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar-client-go] tisonkun commented on pull request #1007: ci: stablize golangci-lint task

Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #1007:
URL: https://github.com/apache/pulsar-client-go/pull/1007#issuecomment-1501954202

   @shibd Yep. So the problem is that we are using an action that can produce some unpredictable issues, also we can hardly run it locally - said other projects use a different version but either of them installed in `$GOBIN/golangci-lint`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar-client-go] tisonkun commented on pull request #1007: ci: stablize golangci-lint task

Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #1007:
URL: https://github.com/apache/pulsar-client-go/pull/1007#issuecomment-1502608301

   > But I am very curious why httpclient can pass the previous CI. It has already been introduced in 2021. The old golangci-lint we used has the ability for ignoring old files?
   
   I bump the golangci-lint to 1.51.2 because original 1.50.1 doesn't work locally for unknown reason - I don't spend time to figure it out but simply do a small version bump.
   
   Besides, it's a false positive on bodyclose linter. There are a few false positive reports upstream, like https://github.com/timakin/bodyclose/issues/42.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org