You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by "plainheart (via GitHub)" <gi...@apache.org> on 2024/05/07 09:55:36 UTC
[PR] fix(series): avoid NPE caused by `seriesData.getLinkedData` [echarts]
plainheart opened a new pull request, #19901:
URL: https://github.com/apache/echarts/pull/19901
## Brief Information
This pull request is in the type of:
- [x] bug fixing
- [ ] new feature
- [ ] others
### What does this PR do?
`getLinkedData` might not exist in some series data, which causes an NPE. This PR adds a non-null check to avoid this error.
See this [online demo](https://echarts.apache.org/examples/editor.html?c=line-simple&code=PYBwLglsB2AEC8sDeAoWsAeBBDEDOAXMrHgBbADuRAZgIYA2eApgDSxgCeITRA5AG4MArk15sAthGhEADBNoYiAVhkBmWAF8WaWBxz4iSEuSqw6jVuy49YA4aIlTZ8xbAAcARhmbt6ZgCcIJkJYAG0ddFR0aNhoWnEbXkAbLMBo50AwDUAAOUB35QBqMQjozm4-AHN_WhBSfJj0AGNgYH8AEylaMCYAZQ48dvE-Wtp_drwIWmgAJibqmrwOcQAjYHp-iH9a-gcC9CZxStoRkKNqYFqhEN5aJoArWlqmaFqOXh8t2AAvIlVfGYGNgBkIJIwIZYJJpLAZAA6JQuIjjF41WBNcolEq0eYbIhgfwib4xfzAeJ8PC_TaI-jopjLZCvPwmLE41i02AgYAjSAwPiLMBgYDiaaI-r0Rpcim1ADWApqx2gYAA6kwICVSMDbIt6FNXlpXk02rQiOFEZFmehBPQRAaACyqOSwcZKADsAF08UaIE0-B4pYi4gk-IBTRUAMgGAcGNAD_a3pmc3VHQgbxsSg8rsRbWxEHmQmGhm1RuiEF6HU4mOIQpFtgAxKp5rRxg7xs8NMzs0aojnYGaLWFLQA2NxsHuWl0m2Duvh1pM1X2JQAA-oBF5UAI5GAYGDAEPKgGAAiMxWYLJYxuNwuRDlOBdOZ5BNnN5nYFjhFowl_x8MvUWpuS1KOuaRvj42ttv2K1uB02FUcYu0HH8R1sVR12iSc-AVeZYEAWSVAHuvaC_CjbdY3jABOL9okPNMM2CLM8PQC9xCvG9YDvB9sNoLsZHmS160_ZkWxzdsbFCcZVF7WAPHGDwwNbCDeGY0jYniRJAFmVQAUvUAeH1ADAlQBquTQkgMPoHd40TA8eSPIjDjPN180LGxbyWUteDLJhaAdWp7
JYnMjJidijU4g1VGwy02DfbDhPPD1bCUNTYNsQAAo0AenNAHDTQBjCzUzdoywvcJII49iNPCTyMoszqIs-9y1qah5jcFRHKNZzolcxF3LCEDE1gVQuz8zLAt4LsQqkvhABG_QA3uUAZL1AE7TQAJC3ijStOUQDdNTNLDMykzrxymjy0tJgmBkJoHTKxEKu_VsatCASYQartQJavhNok0LeEAB1NAHVtKLAC1lWAAGFYGQ2B4NgSLAEgEwBo9VGrdNKS2BLR0n9UoMkihyy0yQSWqymEa7C3FqLaah2mkf32njbSUJR_LdVq3A6v1IIAEVgQBVHUALk9AGAYwAUDwBxLd1gBiUr0wiTyQDGyPmqj4espGUbRmIMaqmp9o8bCjstS1nTO2xsJJxJAEAEwBC7WGpnMJZ7t2emyGMuhvnFryh8mAGXilY_Jy8PFmJ9sawDWdfAnEVErxlb4QAgcMAfDySmAABaO5_GCWdFy1oGWZtPX9K5nnh2NuHTfLJrPKYZjrfK22hwdlQ2AdGQhIV3gPC9S7OtsRS-sUwALCPDiSEu1-NJvBjmZqh8DE-LZOrOw6gHVUWpNsz7bXld2AmCaEp0sNZsSGAIQ1kSMd2EGafVV4K2xfnxe7lHMRV_8dfPRketbZ3pf97YMA16YDfS7PtiL73yCD5vo-789R-cyMPAF8v1-19b4b3fNvP-u9EhQSAR_DewUERz3AQA3gUDD7H1sMPMB_8X7ILfsAvgxN4GIl_lgxIwVoFoLEt_BBJC-BkNQZ_dBVCiHP1IbgmB-CmE1GIRA86bCKFwMwTwxh5CGFtU4S5FhvCREby3ufRB2ClbSJPiLWA496BSE6LDbuwp8q8EaGMaeB9Tj-H4PcYIIRbQUHdGAUgRB6pFESH_dRUwR6EMxhOCuvBAD9foAP7UIwOL4Oo6AwQIz1EaC0OI7Qug9B2P0QYwxRgTCmOOJg1BqDm1VHbYwlAGS4mZNiWgEB6B_HuCUGx
zhmSN2pLwWoqx1hkiNPDEOyTKljWBl2PC9RoA9DGGADo3BJ5EAYlqccHx-Ljl1DfA0bEhxhOaCEWeP5Qjdj4v2ceiIDrSzYLLZ0Q4nSsR_rMho8zpk_nQMsnsfYXzrJqKER2fYXZ7IOc2I54SFlDnOSsq5A4JLnNUHnWABchJPJtjMn8cymjvLOZ2ACQEQI3JiMs6OdpHT7J_GirOYLWwQqhWc5ZsKGrwt-Z2S5rNrkgsxYc8FxzIWnLxZaAlwFTofLCJ5bysBfIYpzFy9G2dqVvLpUshlTsmUIuiAde0QETo8sRDK6IYtXknLCCy_FIqiUqpxj5fGFLtp8uxTS3FSy2U-XGM1DVvE2ACWBei55RDFW0uVdCu5XkTVmqdYdKVoEdW8qxTmHFgrWzOvZZy4l3FkV4zlTESNbiXL2sNYGj1x1mVOuNRy010b0DRoVfypViyE2SqTWK85dUpV-W9aLPVfqDUBpzBKo6jVk14qljLOWGbVG2q4XGmtRpNktvliq-5zttU2qcmPAoDZM0oA0AAbiAA&version=PR-19901)
### Fixed issues
- Resolves #19900
## Details
### Before: What was the problem?
Chart rendered but thrown an error.
### After: How does it behave after the fixing?
Chart rendered without error.
## Document Info
One of the following should be checked.
- [x] This PR doesn't relate to document changes
- [ ] The document should be updated later
- [ ] The document changes have been made in apache/echarts-doc#xxx
## Misc
### ZRender Changes
- [ ] This PR depends on ZRender changes (ecomfe/zrender#xxx).
### Related test cases or examples to use the new APIs
See the 4th case in `test/graph-case.html`.
## Others
### Merging options
- [ ] Please squash the commits into a single one when merging.
### Other information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
Re: [PR] fix(series): avoid NPE caused by `seriesData.getLinkedData` [echarts]
Posted by "echarts-bot[bot] (via GitHub)" <gi...@apache.org>.
echarts-bot[bot] commented on PR #19901:
URL: https://github.com/apache/echarts/pull/19901#issuecomment-2099878563
Congratulations! Your PR has been merged. Thanks for your contribution! 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
Re: [PR] fix(series): avoid NPE caused by `seriesData.getLinkedData` [echarts]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19901:
URL: https://github.com/apache/echarts/pull/19901#issuecomment-2097922367
<!-- ECHARTS_PR_PREVIEW -->
The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-19901@ea0da63
<!-- ECHARTS_PR_PREVIEW -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
Re: [PR] fix(series): avoid NPE caused by `seriesData.getLinkedData` [echarts]
Posted by "echarts-bot[bot] (via GitHub)" <gi...@apache.org>.
echarts-bot[bot] commented on PR #19901:
URL: https://github.com/apache/echarts/pull/19901#issuecomment-2097911103
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request).
The pull request is marked to be `PR: author is committer` because you are a committer of this project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
Re: [PR] fix(series): avoid NPE caused by `seriesData.getLinkedData` [echarts]
Posted by "Ovilia (via GitHub)" <gi...@apache.org>.
Ovilia merged PR #19901:
URL: https://github.com/apache/echarts/pull/19901
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
Re: [PR] fix(series): avoid NPE caused by `seriesData.getLinkedData` [echarts]
Posted by "tab91622 (via GitHub)" <gi...@apache.org>.
tab91622 commented on PR #19901:
URL: https://github.com/apache/echarts/pull/19901#issuecomment-2100030742
@plainheart Great, thank you!大佬
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org