[GitHub] [netbeans] matthiasblaesing commented on a change in pull request #2309: Various improvements inspired by working on VSCode extension

[GitBox <gi...@apache.org>]

matthiasblaesing commented on a change in pull request #2309:
URL: https://github.com/apache/netbeans/pull/2309#discussion_r472361995



##########
File path: java/java.lsp.server/vscode/.vscode/tasks.json
##########
@@ -0,0 +1,20 @@
+// See https://go.microsoft.com/fwlink/?LinkId=733558
+// for the documentation about the tasks.json format

Review comment:
       I noticed this in other JSON files aswell. Are these files from upstream somewhere or authored? This is not valid JSON (there is no comment in JSON (rfc7159)).

##########
File path: java/maven/src/org/netbeans/modules/maven/api/execute/RunUtils.java
##########
@@ -218,4 +219,10 @@ public static boolean hasTestCompileOnSaveEnabled(RunConfig config) {
         return false;
     }
 
+    private static void invokeLaterWithUI(Runnable runnable) {
+        if (GraphicsEnvironment.isHeadless()) {
+            return;
+        }

Review comment:
       This looks a bit strange - is this intended, that this invocation silently drops the execution of the runnable? I would be a bit surprised if trying to debug.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists