You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "mosche (via GitHub)" <gi...@apache.org> on 2023/05/11 11:36:32 UTC
[GitHub] [beam] mosche opened a new pull request, #26666: Support configuration of maxCapacityPerShard when reading from Kinesis with EFO
mosche opened a new pull request, #26666:
URL: https://github.com/apache/beam/pull/26666
Support configuration of maxCapacityPerShard when reading from Kinesis with EFO
(closes #26257)
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] mosche commented on pull request #26666: Support configuration of maxCapacityPerShard when reading from Kinesis with EFO
Posted by "mosche (via GitHub)" <gi...@apache.org>.
mosche commented on PR #26666:
URL: https://github.com/apache/beam/pull/26666#issuecomment-1545309253
Thanks @psolomin, good catch! I've addressed your comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] mosche merged pull request #26666: Support configuration of maxCapacityPerShard when reading from Kinesis with EFO
Posted by "mosche (via GitHub)" <gi...@apache.org>.
mosche merged PR #26666:
URL: https://github.com/apache/beam/pull/26666
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] mosche commented on pull request #26666: Support configuration of maxCapacityPerShard when reading from Kinesis with EFO
Posted by "mosche (via GitHub)" <gi...@apache.org>.
mosche commented on PR #26666:
URL: https://github.com/apache/beam/pull/26666#issuecomment-1543835866
R: @psolomin
R: @aromanenko-dev
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] psolomin commented on a diff in pull request #26666: Support configuration of maxCapacityPerShard when reading from Kinesis with EFO
Posted by "psolomin (via GitHub)" <gi...@apache.org>.
psolomin commented on code in PR #26666:
URL: https://github.com/apache/beam/pull/26666#discussion_r1191734695
##########
sdks/java/io/amazon-web-services2/src/main/java/org/apache/beam/sdk/io/aws2/kinesis/KinesisIO.java:
##########
@@ -615,7 +614,15 @@ public Read withCustomRateLimitPolicy(RateLimitPolicyFactory rateLimitPolicyFact
return toBuilder().setRateLimitPolicyFactory(rateLimitPolicyFactory).build();
}
- /** Specifies the maximum number of messages per one shard. */
+ /**
+ * Specifies the maximum number of messages per one shard.
+ *
+ * <p>Note: When using consumers with dedicated throughput (Enhanced Fan-Out), this capacity
+ * corresponds to the number of in-flight shard events which itself can contain multiple,
+ * potentially even aggregated records.
+ *
+ * @see {@link #withConsumerArn(String)}
+ */
public Read withMaxCapacityPerShard(Integer maxCapacity) {
Review Comment:
Looks like the line 228 should be updated too:
```
* <p>When EFO is enabled, the following configurations are ignored:
*
* <ul>
* <li>{@link Read#withMaxCapacityPerShard(Integer)} <--- drop this?
* <li>{@link Read#withRequestRecordsLimit(int)}
```
##########
sdks/java/io/amazon-web-services2/src/main/java/org/apache/beam/sdk/io/aws2/kinesis/EFOShardSubscribersPool.java:
##########
@@ -470,6 +472,10 @@ String getPoolId() {
return poolId;
}
+ public int getMaxCapacityPerShard() {
Review Comment:
```suggestion
int getMaxCapacityPerShard() {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #26666: Support configuration of maxCapacityPerShard when reading from Kinesis with EFO
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26666:
URL: https://github.com/apache/beam/pull/26666#issuecomment-1543837243
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org