You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2019/08/07 18:55:14 UTC

[GitHub] [nifi-minifi-cpp] nghiaxlee commented on a change in pull request #621: MINIFICPP-959: Review librdkafka thread safety

nghiaxlee commented on a change in pull request #621: MINIFICPP-959: Review librdkafka thread safety
URL: https://github.com/apache/nifi-minifi-cpp/pull/621#discussion_r311711434
 
 

 ##########
 File path: extensions/librdkafka/PublishKafka.h
 ##########
 @@ -291,10 +99,9 @@ class KafkaPool {
  private:
 
 Review comment:
   I did not init connection here because the init function has flowfile as parameter (albeit currently the function does not use any flowfile attribute)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services