You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Daryn Sharp (JIRA)" <ji...@apache.org> on 2011/03/09 20:43:59 UTC
[jira] Created: (HADOOP-7176) Redesign FsShell
Redesign FsShell
----------------
Key: HADOOP-7176
URL: https://issues.apache.org/jira/browse/HADOOP-7176
Project: Hadoop Common
Issue Type: Bug
Affects Versions: 0.22.0
Reporter: Daryn Sharp
Fix For: 0.22.0
The FsShell commands are very tightly coupled together which makes it necessarily hard to write new commands. There is a lot of redundancy between the commands, inconsistencies in handling of paths, handling of errors, and correct return of exit codes. The FsShell commands should be subclasses of the fs.shell.Command class which is already being used by the -count command, and is used by other commands like dfsadmin.
This will serve as an umbrella bug to track the changes.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7176) Redesign FsShell
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J updated HADOOP-7176:
----------------------------
Fix Version/s: (was: 0.24.0)
0.23.0
> Redesign FsShell
> ----------------
>
> Key: HADOOP-7176
> URL: https://issues.apache.org/jira/browse/HADOOP-7176
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Fix For: 0.23.0
>
>
> The FsShell commands are very tightly coupled together which makes it necessarily hard to write new commands. There is a lot of redundancy between the commands, inconsistencies in handling of paths, handling of errors, and correct return of exit codes. The FsShell commands should be subclasses of the fs.shell.Command class which is already being used by the -count command, and is used by other commands like dfsadmin.
> This will serve as an umbrella bug to track the changes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HADOOP-7176) Redesign FsShell
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13004799#comment-13004799 ]
Jakob Homan commented on HADOOP-7176:
-------------------------------------
What do you mean by offline? Design discussions should be on JIRA.
> Redesign FsShell
> ----------------
>
> Key: HADOOP-7176
> URL: https://issues.apache.org/jira/browse/HADOOP-7176
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Daryn Sharp
> Fix For: 0.22.0
>
>
> The FsShell commands are very tightly coupled together which makes it necessarily hard to write new commands. There is a lot of redundancy between the commands, inconsistencies in handling of paths, handling of errors, and correct return of exit codes. The FsShell commands should be subclasses of the fs.shell.Command class which is already being used by the -count command, and is used by other commands like dfsadmin.
> This will serve as an umbrella bug to track the changes.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7176) Redesign FsShell
Posted by "Daryn Sharp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13028751#comment-13028751 ]
Daryn Sharp commented on HADOOP-7176:
-------------------------------------
This bug is implicitly fixing bugs in all the commands regarding handling of globs and exit codes of 0 when multiple args and/or globs are supplied and have errors. If anyone has available time, I'd like to please request reviews for the linked bugs. Thanks in advance.
> Redesign FsShell
> ----------------
>
> Key: HADOOP-7176
> URL: https://issues.apache.org/jira/browse/HADOOP-7176
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Fix For: 0.22.0
>
>
> The FsShell commands are very tightly coupled together which makes it necessarily hard to write new commands. There is a lot of redundancy between the commands, inconsistencies in handling of paths, handling of errors, and correct return of exit codes. The FsShell commands should be subclasses of the fs.shell.Command class which is already being used by the -count command, and is used by other commands like dfsadmin.
> This will serve as an umbrella bug to track the changes.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7176) Redesign FsShell
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13014344#comment-13014344 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-7176:
------------------------------------------------
> What do you mean by offline? Design discussions should be on JIRA.
Hey Jakob, I seems to recall that you sometimes have design discussions with other people privately. No?
> Redesign FsShell
> ----------------
>
> Key: HADOOP-7176
> URL: https://issues.apache.org/jira/browse/HADOOP-7176
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Fix For: 0.22.0
>
>
> The FsShell commands are very tightly coupled together which makes it necessarily hard to write new commands. There is a lot of redundancy between the commands, inconsistencies in handling of paths, handling of errors, and correct return of exit codes. The FsShell commands should be subclasses of the fs.shell.Command class which is already being used by the -count command, and is used by other commands like dfsadmin.
> This will serve as an umbrella bug to track the changes.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HADOOP-7176) Redesign FsShell
Posted by "Daryn Sharp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13004797#comment-13004797 ]
Daryn Sharp commented on HADOOP-7176:
-------------------------------------
Definitively maintaining backwards compatibility. Let's discuss #2 offline.
> Redesign FsShell
> ----------------
>
> Key: HADOOP-7176
> URL: https://issues.apache.org/jira/browse/HADOOP-7176
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Daryn Sharp
> Fix For: 0.22.0
>
>
> The FsShell commands are very tightly coupled together which makes it necessarily hard to write new commands. There is a lot of redundancy between the commands, inconsistencies in handling of paths, handling of errors, and correct return of exit codes. The FsShell commands should be subclasses of the fs.shell.Command class which is already being used by the -count command, and is used by other commands like dfsadmin.
> This will serve as an umbrella bug to track the changes.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7176) Redesign FsShell
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13461179#comment-13461179 ]
Harsh J commented on HADOOP-7176:
---------------------------------
This had already gone in 0.23.0 (per the tag sources). 0.24 is a non-existent version, so changed the Fix Version to point to 0.23.0 where this was apparently already completed.
> Redesign FsShell
> ----------------
>
> Key: HADOOP-7176
> URL: https://issues.apache.org/jira/browse/HADOOP-7176
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Fix For: 0.23.0
>
>
> The FsShell commands are very tightly coupled together which makes it necessarily hard to write new commands. There is a lot of redundancy between the commands, inconsistencies in handling of paths, handling of errors, and correct return of exit codes. The FsShell commands should be subclasses of the fs.shell.Command class which is already being used by the -count command, and is used by other commands like dfsadmin.
> This will serve as an umbrella bug to track the changes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HADOOP-7176) Redesign FsShell
Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13004786#comment-13004786 ]
Olga Natkovich commented on HADOOP-7176:
----------------------------------------
Pig project uses FsShell to export HDFS commands to the users. Things that are important to us:
(1) Backward compatibility
(2) Better error handling. At this point if command fails it seems to always return -1 so we can't tell different problems apart.
> Redesign FsShell
> ----------------
>
> Key: HADOOP-7176
> URL: https://issues.apache.org/jira/browse/HADOOP-7176
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Daryn Sharp
> Fix For: 0.22.0
>
>
> The FsShell commands are very tightly coupled together which makes it necessarily hard to write new commands. There is a lot of redundancy between the commands, inconsistencies in handling of paths, handling of errors, and correct return of exit codes. The FsShell commands should be subclasses of the fs.shell.Command class which is already being used by the -count command, and is used by other commands like dfsadmin.
> This will serve as an umbrella bug to track the changes.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (HADOOP-7176) Redesign FsShell
Posted by "Daryn Sharp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daryn Sharp reassigned HADOOP-7176:
-----------------------------------
Assignee: Daryn Sharp
> Redesign FsShell
> ----------------
>
> Key: HADOOP-7176
> URL: https://issues.apache.org/jira/browse/HADOOP-7176
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Fix For: 0.22.0
>
>
> The FsShell commands are very tightly coupled together which makes it necessarily hard to write new commands. There is a lot of redundancy between the commands, inconsistencies in handling of paths, handling of errors, and correct return of exit codes. The FsShell commands should be subclasses of the fs.shell.Command class which is already being used by the -count command, and is used by other commands like dfsadmin.
> This will serve as an umbrella bug to track the changes.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HADOOP-7176) Redesign FsShell
Posted by "Daryn Sharp (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daryn Sharp resolved HADOOP-7176.
---------------------------------
Resolution: Fixed
Fix Version/s: 0.24.0
These changes were completed long ago. Closing.
> Redesign FsShell
> ----------------
>
> Key: HADOOP-7176
> URL: https://issues.apache.org/jira/browse/HADOOP-7176
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Fix For: 0.24.0
>
>
> The FsShell commands are very tightly coupled together which makes it necessarily hard to write new commands. There is a lot of redundancy between the commands, inconsistencies in handling of paths, handling of errors, and correct return of exit codes. The FsShell commands should be subclasses of the fs.shell.Command class which is already being used by the -count command, and is used by other commands like dfsadmin.
> This will serve as an umbrella bug to track the changes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HADOOP-7176) Redesign FsShell
Posted by "Daryn Sharp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13004803#comment-13004803 ]
Daryn Sharp commented on HADOOP-7176:
-------------------------------------
My apologies, we are both yahoos so I figured we could internally discuss and then summarize for approval.
> Redesign FsShell
> ----------------
>
> Key: HADOOP-7176
> URL: https://issues.apache.org/jira/browse/HADOOP-7176
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Daryn Sharp
> Fix For: 0.22.0
>
>
> The FsShell commands are very tightly coupled together which makes it necessarily hard to write new commands. There is a lot of redundancy between the commands, inconsistencies in handling of paths, handling of errors, and correct return of exit codes. The FsShell commands should be subclasses of the fs.shell.Command class which is already being used by the -count command, and is used by other commands like dfsadmin.
> This will serve as an umbrella bug to track the changes.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7176) Redesign FsShell
Posted by "Konstantin Shvachko (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Shvachko updated HADOOP-7176:
----------------------------------------
Fix Version/s: (was: 0.22.0)
> Redesign FsShell
> ----------------
>
> Key: HADOOP-7176
> URL: https://issues.apache.org/jira/browse/HADOOP-7176
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
>
> The FsShell commands are very tightly coupled together which makes it necessarily hard to write new commands. There is a lot of redundancy between the commands, inconsistencies in handling of paths, handling of errors, and correct return of exit codes. The FsShell commands should be subclasses of the fs.shell.Command class which is already being used by the -count command, and is used by other commands like dfsadmin.
> This will serve as an umbrella bug to track the changes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira