You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "jscheffl (via GitHub)" <gi...@apache.org> on 2026/02/02 15:09:12 UTC
[PR] Remove some global variables in airflow.settings [airflow]
jscheffl opened a new pull request, #61356:
URL: https://github.com/apache/airflow/pull/61356
Another small increment to remove `global` statements for PR https://github.com/apache/airflow/pull/58116
This removes (some) global statements from settings.py where the a lot of state was hold in variables used with global and then a lot of code way relying to access these globals. Is a like a public interface and refactoring would be needed. Attempting to re-sort initialization order to get rid of global.
`global` is evil.
Note that usage of `glocal` in ORM engine will be a separate PR
---
##### Was generative AI tooling used to co-author this PR?
- [ ] No (please specify the tool below)
---
* Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment: `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove some global variables in airflow.settings [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on PR #61356:
URL: https://github.com/apache/airflow/pull/61356#issuecomment-3865018395
Need some other attempt...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove some global variables in airflow.settings [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl closed pull request #61356: Remove some global variables in airflow.settings
URL: https://github.com/apache/airflow/pull/61356
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove some global variables in airflow.settings [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl closed pull request #61356: Remove some global variables in airflow.settings
URL: https://github.com/apache/airflow/pull/61356
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org