You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@avro.apache.org by GitBox <gi...@apache.org> on 2022/02/01 18:31:41 UTC

[GitHub] [avro] RyanSkraba commented on a change in pull request #1457: AVRO-3305: Only mangle type identifier keywords when used as types

RyanSkraba commented on a change in pull request #1457:
URL: https://github.com/apache/avro/pull/1457#discussion_r795944416



##########
File path: lang/java/avro/src/main/java/org/apache/avro/specific/SpecificData.java
##########
@@ -103,8 +103,6 @@
       "throw", "throws", "transient", "try", "void", "volatile", "while",
       // Literals from Section 3.10 can't be used as identifiers.
       "true", "false", "null",
-      // Some keywords from Section 3.8 can't be used as type identifiers.
-      "var", "yield", "record",

Review comment:
       These RESERVED_WORDS are also used in Enum *symbols* in `createEnum` below -- I'm guessing enum symbols in java don't need to be mangled, it's still fine removing them here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org