[GitHub] [ignite] timoninmaxim commented on a change in pull request #8294: IGNITE-13492: Basic snapshot test

[GitBox <gi...@apache.org>]

timoninmaxim commented on a change in pull request #8294:
URL: https://github.com/apache/ignite/pull/8294#discussion_r504712800



##########
File path: modules/ducktests/pom.xml
##########
@@ -188,6 +193,23 @@
                             <excludeTransitive>false</excludeTransitive>
                         </configuration>
                     </execution>
+                    <execution>

Review comment:
       is it possible to make it as we do for jackson dependencies? Check specs implementation, `__jackson` method

##########
File path: modules/ducktests/tests/ignitetest/services/utils/control_utility.py
##########
@@ -259,8 +364,8 @@ def __run(self, cmd):
 
         return output
 
-    def __form_cmd(self, node, cmd):
-        return self._cluster.spec.path.script(f"{self.BASE_COMMAND} --host {node.account.externally_routable_ip} {cmd}")
+    def __form_cmd(self, cmd):
+        return self._cluster.spec.path.script(f"{self.BASE_COMMAND} --host `hostname -i` {cmd}")

Review comment:
       from man "Display the IP address**(es)** of the host". So is it ok that there could be multiple IP addresses  for the host param?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org