You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "andygrove (via GitHub)" <gi...@apache.org> on 2023/04/28 03:24:16 UTC
[GitHub] [arrow-datafusion-python] andygrove opened a new pull request, #355: Add benchmark derived from TPC-H
andygrove opened a new pull request, #355:
URL: https://github.com/apache/arrow-datafusion-python/pull/355
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
N/A
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
Make it easier to run benchmarks so we can track performance between releases and catch regressions earlier.
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion-python] jdye64 commented on a diff in pull request #355: Add benchmark derived from TPC-H
Posted by "jdye64 (via GitHub)" <gi...@apache.org>.
jdye64 commented on code in PR #355:
URL: https://github.com/apache/arrow-datafusion-python/pull/355#discussion_r1181570518
##########
benchmarks/tpch/create_tables.sql:
##########
@@ -0,0 +1,133 @@
+-- Licensed to the Apache Software Foundation (ASF) under one
Review Comment:
Should this also contain the disclaimer about being derived from TPC-H since it is performing DDL? Don't know the answer there?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion-python] andygrove commented on a diff in pull request #355: Add benchmark derived from TPC-H
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on code in PR #355:
URL: https://github.com/apache/arrow-datafusion-python/pull/355#discussion_r1183660142
##########
benchmarks/tpch/create_tables.sql:
##########
@@ -0,0 +1,133 @@
+-- Licensed to the Apache Software Foundation (ASF) under one
Review Comment:
Good point. I will go ahead and add this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion-python] andygrove commented on a diff in pull request #355: Add benchmark derived from TPC-H
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on code in PR #355:
URL: https://github.com/apache/arrow-datafusion-python/pull/355#discussion_r1180394188
##########
dev/release/rat_exclude_files.txt:
##########
@@ -42,4 +42,5 @@ Cargo.lock
.history
*rat.txt
*/.git
-.github/*
\ No newline at end of file
+.github/*
+benchmarks/tpch/queries/q*.sql
Review Comment:
The queries are copyright TPC so we can't claim ASF copyright
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion-python] andygrove merged pull request #355: Add benchmark derived from TPC-H
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove merged PR #355:
URL: https://github.com/apache/arrow-datafusion-python/pull/355
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion-python] andygrove commented on pull request #355: Add benchmark derived from TPC-H
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on PR #355:
URL: https://github.com/apache/arrow-datafusion-python/pull/355#issuecomment-1526959442
@kylebrooks-8451 fyi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org