You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by vanzin <gi...@git.apache.org> on 2018/06/12 16:56:43 UTC

[GitHub] spark pull request #21523: [SPARK-24506][UI] Add UI filters to tabs added af...

Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21523#discussion_r194814773
  
    --- Diff: core/src/main/scala/org/apache/spark/ui/WebUI.scala ---
    @@ -91,7 +91,12 @@ private[spark] abstract class WebUI(
       /** Attach a handler to this UI. */
       def attachHandler(handler: ServletContextHandler) {
         handlers += handler
    -    serverInfo.foreach(_.addHandler(handler))
    +    serverInfo.foreach { sInfo =>
    --- End diff --
    
    I'm still working on it since it touches a bunch of other things, not just this. This is fine as is, it's better to have a more targeted fix here and leave my PR just as refactoring.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org