You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/04/04 13:02:21 UTC
[GitHub] [flink] XComp opened a new pull request, #19353: [FLINK-27050][runtime] Removes default RpcSystem instance
XComp opened a new pull request, #19353:
URL: https://github.com/apache/flink/pull/19353
## What is the purpose of the change
Having a default RpcSystem in TestingDispatcher.Builder
caused threads being spawned without cleanup. Instead, we
should rely on the RpcSystem instance provided by the test.
## Brief change log
* Removed the default instance from TestingDispatcher.Builder and made it a required parameter through the `build` method
## Verifying this change
* Running a test manually in a loop and checking that there are no threads left hanging, e.g. in `DispatcherCleanupResourcesTest`:
```
@Test
public void foo() throws Exception {
for (int i = 0; i < 100; i++) {
setup();
testDuplicateJobSubmissionDoesNotDeleteJobMetaData();
teardown();
}
System.out.println("Stop the debugger here");
}
```
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] XComp commented on pull request #19353: [FLINK-27050][runtime] Removes default RpcSystem instance
Posted by GitBox <gi...@apache.org>.
XComp commented on PR #19353:
URL: https://github.com/apache/flink/pull/19353#issuecomment-1091186266
Again force-pushed without any additional changes to trigger ci once more...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #19353: [FLINK-27050][runtime] Removes default RpcSystem instance
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #19353:
URL: https://github.com/apache/flink/pull/19353#issuecomment-1087537918
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a942ecbc4be8adf0ee037228ad9ebc697b7e6080",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a942ecbc4be8adf0ee037228ad9ebc697b7e6080",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a942ecbc4be8adf0ee037228ad9ebc697b7e6080 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] XComp commented on pull request #19353: [FLINK-27050][runtime] Removes default RpcSystem instance
Posted by GitBox <gi...@apache.org>.
XComp commented on PR #19353:
URL: https://github.com/apache/flink/pull/19353#issuecomment-1090168304
Force push without changes to trigger the CI since the `run azure` didn't seem to have worked...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] XComp commented on pull request #19353: [FLINK-27050][runtime] Removes default RpcSystem instance
Posted by GitBox <gi...@apache.org>.
XComp commented on PR #19353:
URL: https://github.com/apache/flink/pull/19353#issuecomment-1091847774
Rebased to most-recent `master`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] XComp commented on pull request #19353: [FLINK-27050][runtime] Removes default RpcSystem instance
Posted by GitBox <gi...@apache.org>.
XComp commented on PR #19353:
URL: https://github.com/apache/flink/pull/19353#issuecomment-1096826291
Force-pushed once more after the branch idle'd for 5 days to prepare the merge for tomorrow morning...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] XComp commented on pull request #19353: [FLINK-27050][runtime] Removes default RpcSystem instance
Posted by GitBox <gi...@apache.org>.
XComp commented on PR #19353:
URL: https://github.com/apache/flink/pull/19353#issuecomment-1089936696
I'm investigating the OOM in the integration tests of the `flink-tests` module ([ci run](https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=34234&view=logs&j=a57e0635-3fad-5b08-57c7-a4142d7d6fa9&t=2ef0effc-1da1-50e5-c2bd-aab434b1c5b7)). In the mean time, I'm gonna start another ci run
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] XComp merged pull request #19353: [FLINK-27050][runtime] Removes default RpcSystem instance
Posted by GitBox <gi...@apache.org>.
XComp merged PR #19353:
URL: https://github.com/apache/flink/pull/19353
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on pull request #19353: [FLINK-27050][runtime] Removes default RpcSystem instance
Posted by GitBox <gi...@apache.org>.
zentol commented on PR #19353:
URL: https://github.com/apache/flink/pull/19353#issuecomment-1091724448
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] XComp commented on pull request #19353: [FLINK-27050][runtime] Removes default RpcSystem instance
Posted by GitBox <gi...@apache.org>.
XComp commented on PR #19353:
URL: https://github.com/apache/flink/pull/19353#issuecomment-1089936918
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] XComp commented on pull request #19353: [FLINK-27050][runtime] Removes default RpcSystem instance
Posted by GitBox <gi...@apache.org>.
XComp commented on PR #19353:
URL: https://github.com/apache/flink/pull/19353#issuecomment-1098028227
Error caused by FLINK-26621 which is unrelated to this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org