You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by hsuanyi <gi...@git.apache.org> on 2015/11/13 04:29:33 UTC
[GitHub] drill pull request: DRILL-4083: ScanPrel's CPU cost should not be ...
GitHub user hsuanyi opened a pull request:
https://github.com/apache/drill/pull/253
DRILL-4083: ScanPrel's CPU cost should not be zero even if column cou…
…nt is zero
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hsuanyi/incubator-drill DRILL-4083
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/253.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #253
----
commit 736057564b70ff14b14b9ed3f5419979169d6fac
Author: Hsuan-Yi Chu <hs...@usc.edu>
Date: 2015-11-12T23:01:10Z
DRILL-4083: ScanPrel's CPU cost should not be zero even if column count is zero
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-4083: ScanPrel's CPU cost should not be ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/253
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-4083: ScanPrel's CPU cost should not be ...
Posted by jinfengni <gi...@git.apache.org>.
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/253#discussion_r44845244
--- Diff: contrib/storage-hive/core/src/test/java/org/apache/drill/exec/hive/TestHiveStorage.java ---
@@ -36,6 +36,19 @@ public static void setupOptions() throws Exception {
test(String.format("alter session set `%s` = true", PlannerSettings.ENABLE_DECIMAL_DATA_TYPE_KEY));
}
+
+ @Test // DRILL-4083
+ public void testNativeScanWhenNoColumnIsRead() throws Exception {
+ try {
+ test(String.format("alter session set `%s` = true", ExecConstants.HIVE_OPTIMIZE_SCAN_WITH_NATIVE_READERS));
+
+ String query = "SELECT count(*) FROM hive.readtest_parquet";
+ testPhysicalPlan(query, "hive-drill-native-parquet-scan");
+ } finally {
+ test(String.format("alter session set `%s` = false", ExecConstants.HIVE_OPTIMIZE_SCAN_WITH_NATIVE_READERS));
--- End diff --
Will it make sense to change it back to default value in the finally block (in case we change the default value for this option in future release)?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-4083: ScanPrel's CPU cost should not be ...
Posted by hsuanyi <gi...@git.apache.org>.
Github user hsuanyi commented on the pull request:
https://github.com/apache/drill/pull/253#issuecomment-156594216
Addressed reviewer's comment
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-4083: ScanPrel's CPU cost should not be ...
Posted by jinfengni <gi...@git.apache.org>.
Github user jinfengni commented on the pull request:
https://github.com/apache/drill/pull/253#issuecomment-156584940
Overall LGTM.
In case that only constants are used and no column is required from scan operator, the scan operator still has to go through the data source; the cpu costing should not be 0.
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---