You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/06/30 07:23:00 UTC

[jira] [Commented] (BEAM-2515) BeamSql: refactor the MockedBeamSqlTable and related tests

    [ https://issues.apache.org/jira/browse/BEAM-2515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16069635#comment-16069635 ] 

ASF GitHub Bot commented on BEAM-2515:
--------------------------------------

GitHub user xumingming opened a pull request:

    https://github.com/apache/beam/pull/3478

    [BEAM-2515] BeamSql: refactor the MockedBeamSqlTable and related tests

    Summary:
    
    * rename `MockedBeamSqlTable` to `MockedBoundedTable`
    * Use the `RowsBuilder` to build rows in Unit Test.
    * use `PAssert` rather than `assertEquals` when test PCollections.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xumingming/beam BEAM-2515-refactor-mock

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3478.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3478
    
----
commit 1c03838b88b45e2bb32ddf0a8bfe022de68cafc0
Author: James Xu <xu...@gmail.com>
Date:   2017-06-27T02:42:40Z

    use PAssert rather than assertEquals

commit 5b48fc288127429355cc727cadbc657cba719320
Author: James Xu <xu...@gmail.com>
Date:   2017-06-27T09:08:39Z

    minor

commit 40b8962e2f5a66d279801f8d4604c442634d902a
Author: James Xu <xu...@gmail.com>
Date:   2017-06-30T06:54:26Z

    MockedBeamSqlTable -> MockedBoundedTable

----


> BeamSql: refactor the MockedBeamSqlTable and related tests
> ----------------------------------------------------------
>
>                 Key: BEAM-2515
>                 URL: https://issues.apache.org/jira/browse/BEAM-2515
>             Project: Beam
>          Issue Type: Bug
>          Components: dsl-sql
>            Reporter: James Xu
>            Assignee: James Xu
>
> MockedBeamSqlTable is only for Bounded data sources, after another Unbounded mock added, some refactor will be needed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)