You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "RexXiong (via GitHub)" <gi...@apache.org> on 2023/04/22 09:39:02 UTC
[GitHub] [incubator-celeborn] RexXiong opened a new pull request, #1449: [CELEBORN-537][FOLLOWUP] Fix blacklist potentially lost failure workers
RexXiong opened a new pull request, #1449:
URL: https://github.com/apache/incubator-celeborn/pull/1449
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
Record shuttingWorkers & improve remove
### Why are the changes needed?
1. if workers returned by heartbeat contains being removed workers, It would better don't remove from blacklist.
2. blacklist need record every worker in heartbeat workers list. (Currently may lost record shuttingWorkers)
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] RexXiong commented on a diff in pull request #1449: [CELEBORN-537][FOLLOWUP] Fix blacklist potentially lost failure workers
Posted by "RexXiong (via GitHub)" <gi...@apache.org>.
RexXiong commented on code in PR #1449:
URL: https://github.com/apache/incubator-celeborn/pull/1449#discussion_r1174411414
##########
client/src/main/scala/org/apache/celeborn/client/WorkerStatusTracker.scala:
##########
@@ -147,7 +146,12 @@ class WorkerStatusTracker(
StatusCode.PUSH_DATA_TIMEOUT_MASTER |
StatusCode.PUSH_DATA_TIMEOUT_SLAVE
if current - registerTime < workerExcludedExpireTimeout => // reserve
- case _ => blacklist.remove(workerInfo)
+ case _ =>
Review Comment:
Add this code the logic would be more perfect, but if Without some failure workers would be remove for a little while(though this shouldn't be so serious).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] RexXiong commented on a diff in pull request #1449: [CELEBORN-537][FOLLOWUP] Fix blacklist potentially lost failure workers
Posted by "RexXiong (via GitHub)" <gi...@apache.org>.
RexXiong commented on code in PR #1449:
URL: https://github.com/apache/incubator-celeborn/pull/1449#discussion_r1174411414
##########
client/src/main/scala/org/apache/celeborn/client/WorkerStatusTracker.scala:
##########
@@ -147,7 +146,12 @@ class WorkerStatusTracker(
StatusCode.PUSH_DATA_TIMEOUT_MASTER |
StatusCode.PUSH_DATA_TIMEOUT_SLAVE
if current - registerTime < workerExcludedExpireTimeout => // reserve
- case _ => blacklist.remove(workerInfo)
+ case _ =>
Review Comment:
Add this code the logic would be more perfect, but if Without that some failure workers would be remove for a little while(though this shouldn't be so serious).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture commented on a diff in pull request #1449: [CELEBORN-537][FOLLOWUP] Fix blacklist potentially lost failure workers
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture commented on code in PR #1449:
URL: https://github.com/apache/incubator-celeborn/pull/1449#discussion_r1174406008
##########
client/src/main/scala/org/apache/celeborn/client/WorkerStatusTracker.scala:
##########
@@ -147,7 +146,12 @@ class WorkerStatusTracker(
StatusCode.PUSH_DATA_TIMEOUT_MASTER |
StatusCode.PUSH_DATA_TIMEOUT_SLAVE
if current - registerTime < workerExcludedExpireTimeout => // reserve
- case _ => blacklist.remove(workerInfo)
+ case _ =>
Review Comment:
I think this block is unnecessary to change, because the following logic guarantees that blacklist/shutting/unknown workers will be added into blacklist.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture merged pull request #1449: [CELEBORN-537][FOLLOWUP] Fix blacklist potentially lost failure workers
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture merged PR #1449:
URL: https://github.com/apache/incubator-celeborn/pull/1449
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1449: [CELEBORN-537][FOLLOWUP] Fix blacklist potentially lost failure workers
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1449:
URL: https://github.com/apache/incubator-celeborn/pull/1449#issuecomment-1518582383
## [Codecov](https://codecov.io/gh/apache/incubator-celeborn/pull/1449?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1449](https://codecov.io/gh/apache/incubator-celeborn/pull/1449?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (049754c) into [main](https://codecov.io/gh/apache/incubator-celeborn/commit/e3ae2f0e17939ed7f765edea248b55d641603600?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e3ae2f0) will **decrease** coverage by `0.04%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## main #1449 +/- ##
==========================================
- Coverage 44.87% 44.82% -0.04%
==========================================
Files 156 155 -1
Lines 9596 9586 -10
Branches 956 955 -1
==========================================
- Hits 4305 4296 -9
+ Misses 5008 5007 -1
Partials 283 283
```
[see 2 files with indirect coverage changes](https://codecov.io/gh/apache/incubator-celeborn/pull/1449/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org