You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2017/09/29 08:47:14 UTC
Re: Review Request 61174: Added a test
`ProtobufTest.ParseJSONUnrecognizedEnum`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61174/
-----------------------------------------------------------
(Updated Sept. 29, 2017, 4:47 p.m.)
Review request for mesos, Benjamin Mahler and James Peach.
Changes
-------
Updated commit message.
Summary (updated)
-----------------
Added a test `ProtobufTest.ParseJSONUnrecognizedEnum`.
Bugs: MESOS-7828
https://issues.apache.org/jira/browse/MESOS-7828
Repository: mesos
Description (updated)
-------
Added a test `ProtobufTest.ParseJSONUnrecognizedEnum`.
Diffs (updated)
-----
3rdparty/stout/tests/protobuf_tests.cpp 8877e8934e0f7875bfedcfa88b491ce4b13ca44f
3rdparty/stout/tests/protobuf_tests.proto d16726aa8060aea2b830040b20dbdd467c801483
Diff: https://reviews.apache.org/r/61174/diff/4/
Changes: https://reviews.apache.org/r/61174/diff/3-4/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 61174: Added a test
`ProtobufTest.ParseJSONUnrecognizedEnum`.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61174/#review186922
-----------------------------------------------------------
Patch looks great!
Reviews applied: [61109, 61174]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Oct. 2, 2017, 11:14 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61174/
> -----------------------------------------------------------
>
> (Updated Oct. 2, 2017, 11:14 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and James Peach.
>
>
> Bugs: MESOS-7828
> https://issues.apache.org/jira/browse/MESOS-7828
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test `ProtobufTest.ParseJSONUnrecognizedEnum`.
>
>
> Diffs
> -----
>
> 3rdparty/stout/tests/protobuf_tests.cpp 8877e8934e0f7875bfedcfa88b491ce4b13ca44f
> 3rdparty/stout/tests/protobuf_tests.proto d16726aa8060aea2b830040b20dbdd467c801483
>
>
> Diff: https://reviews.apache.org/r/61174/diff/5/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 61174: Added a test
`ProtobufTest.ParseJSONUnrecognizedEnum`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61174/#review186856
-----------------------------------------------------------
FAIL: Some Mesos tests failed.
Reviews applied: `['61109', '61174']`
Failed command: `C:\mesos\src\mesos-tests.exe --verbose --gtest_filter="-ContentType/MasterAPITest.EventAuthorizationFiltering/1"`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/61174
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/61174/logs/mesos-tests-stdout.log):
```
[ RUN ] ContentType/SchedulerTest.SchedulerReconnect/0
[ OK ] ContentType/SchedulerTest.SchedulerReconnect/0 (275 ms)
[ RUN ] ContentType/SchedulerTest.SchedulerReconnect/1
[ OK ] ContentType/SchedulerTest.SchedulerReconnect/1 (290 ms)
[----------] 30 tests from ContentType/SchedulerTest (24698 ms total)
[----------] 2 tests from ContentTypeAndSSLConfig/SchedulerSSLTest
[ RUN ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/0
[ OK ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/0 (933 ms)
[ RUN ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/1
[ OK ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/1 (1054 ms)
[----------] 2 tests from ContentTypeAndSSLConfig/SchedulerSSLTest (2086 ms total)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (138 ms)
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (146 ms)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (324 ms total)
[----------] Global test environment tear-down
[==========] 634 tests from 67 test cases ran. (327717 ms total)
[ PASSED ] 633 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] MesosContainerizer/DefaultExecutorTest.TaskWithFileURI/0, where GetParam() = "mesos"
1 FAILED TEST
YOU HAVE 182 DISABLED TESTS
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/61174/logs/mesos-tests-stderr.log):
```
I1002 17:14:14.179023 38576 master.cpp:8438] Removing framework e37d3e6b-8f3c-4263-8f03-fbb611deefbf-0000 (default)
I1002 17:14:14.179023 38576 master.cpp:3317] Deactivating framework e37d3e6b-8f3c-4263-8f03-fbb611deefbf-0000 (default)
I1002 17:14:14.181025 38440 hierarchical.cpp:412] Deactivated framework e37d3e6b-8f3c-4263-8f03-fbb611deefbf-0000
I1002 17:14:14.181025 36224 slave.cpp:3239] Shutting down framework e37d3e6b-8f3c-4263-8f03-fbb611deefbf-0000
I1002 17:14:14.181025 38576 master.cpp:9136] Updating the state of task 63211a64-803a-41f6-89fe-041bc1b04442 of framework e37d3e6b-8f3c-4263-8f03-fbb611deefbf-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED)
I1002 17:14:14.181025 36224 slave.cpp:5746] Shutting down executor 'default' of framework e37d3e6b-8f3c-4263-8f03-fbb611deefbf-0000 (via HTTP)
I1002 17:14:14.185017 38576 master.cpp:9230] Removing task 63211a64-803a-41f6-89fe-041bc1b04442 with resources [{"allocation_info":{"role":"*"},"name":"cpus","scalar":{"value":2.0},"type":"SCALAR"},{"allocation_info":{"role":"*"},"name":"mem","scalar":{"value":1024.0},"type":"SCALAR"},{"allocation_info":{"role":"*"},"name":"disk","scalar":{"value":1024.0},"type":"SCALAR"},{"allocation_info":{"role":"*"},"name":"ports","ranges":{"range":[{"begin":31000,"end":32000}]},"type":"RANGES"}] of framework e37d3e6b-8f3c-4263-8f03-fbb611deefbf-0000 on agent e37d3e6b-8f3c-4263-8f03-fbb611deefbf-S0 at slave(251)@10.3.1.5:58093 (mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1002 17:14:14.206024 38576 master.cpp:9259] Removing executor 'default' with resources [] of framework e37d3e6b-8f3c-4263-8f03-fbb611deefbf-0000 on agent e37d3e6b-8f3c-4263-8f03-fbb611deefbf-S0 at slave(251)@10.3.1.5:58093 (mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1002 17:14:14.210019 36224 hierarchical.cpp:355] Removed framework e37d3e6b-8f3c-4263-8f03-fbb611deefbf-0000
E1002 17:14:14.210019 38280 scheduler.cpp:649] End-Of-File received from master. The master closed the event stream
I1002 17:14:14.221017 38280 scheduler.cpp:444] Re-detecting master
I1002 17:14:14.223021 38208 scheduler.cpp:470] New master detected at master@10.3.1.5:58093
I1002 17:14:14.240018 38208 slave.cpp:5411] Executor 'default' of framework e37d3e6b-8f3c-4263-8f03-fbb611deefbf-0000 exited with status 0
I1002 17:14:14.240018 38208 slave.cpp:5515] Cleaning up executor 'default' of framework e37d3e6b-8f3c-4263-8f03-fbb611deefbf-0000 (via HTTP)
W1002 17:14:14.241019 37396 master.cpp:7089] Ignoring unknown exited executor 'default' of framework e37d3e6b-8f3c-4263-8f03-fbb611deefbf-0000 on agent e37d3e6b-8f3c-4263-8f03-fbb611deefbf-S0 at slave(251)@10.3.1.5:58093 (mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1002 17:14:14.246021 38440 gc.cpp:90] Scheduling 'C:\Users\mesos\AppData\Local\Temp\2\IK2Urt\slaves\e37d3e6b-8f3c-4263-8f03-fbb611deefbf-S0\frameworks\e37d3e6b-8f3c-4263-8f03-fbb611deefbf-0000\executors\default\runs\c5dd76b1-4f5d-4ad4-bef4-7660515eb034' for gc 6.99998557845926days in the future
I1002 17:14:14.248019 38208 slave.cpp:5622] Cleaning up framework e37d3e6b-8f3c-4263-8f03-fbb611deefbf-0000
I1002 17:14:14.257017 37396 status_update_manager.cpp:285] Closing status update streams for framework e37d3e6b-8f3c-4263-8f03-fbb611deefbf-0000
I1002 17:14:14.257017 38440 gc.cpp:90] Scheduling 'C:\Users\mesos\AppData\Local\Temp\2\IK2Urt\slaves\e37d3e6b-8f3c-4263-8f03-fbb611deefbf-S0\frameworks\e37d3e6b-8f3c-4263-8f03-fbb611deefbf-0000\executors\default' for gc 6.99998556687407days in the future
I1002 17:14:14.257017 38440 gc.cpp:90] Scheduling 'C:\Users\mesos\AppData\Local\Temp\2\IK2Urt\slaves\e37d3e6b-8f3c-4263-8f03-fbb611deefbf-S0\frameworks\e37d3e6b-8f3c-4263-8f03-fbb611deefbf-0000' for gc 6.99998545117926days in the future
I1002 17:14:14.258018 38208 slave.cpp:869] Agent terminating
I1002 17:14:14.259018 38784 master.cpp:1321] Agent e37d3e6b-8f3c-4263-8f03-fbb611deefbf-S0 at slave(251)@10.3.1.5:58093 (mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I1002 17:14:14.267019 38784 master.cpp:3354] Disconnecting agent e37d3e6b-8f3c-4263-8f03-fbb611deefbf-S0 at slave(251)@10.3.1.5:58093 (mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1002 17:14:14.267019 38784 master.cpp:3373] Deactivating agent e37d3e6b-8f3c-4263-8f03-fbb611deefbf-S0 at slave(251)@10.3.1.5:58093 (mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1002 17:14:14.271641 36224 hierarchical.cpp:690] Agent e37d3e6b-8f3c-4263-8f03-fbb611deefbf-S0 deactivated
I1002 17:14:14.289021 38328 master.cpp:1163] Master terminating
I1002 17:14:14.294018 38784 hierarchical.cpp:626] Removed agent e37d3e6b-8f3c-4263-8f03-fbb611deefbf-S0
W1002 17:14:14.306018 38328 master.hpp:2882] Failed to close HTTP pipe for e37d3e6b-8f3c-4263-8f03-fbb611deefbf-0000 (default)
I1002 17:14:15.141026 34456 process.cpp:1068] Failed to accept socket: future discarded
```
- Mesos Reviewbot Windows
On Oct. 2, 2017, 3:14 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61174/
> -----------------------------------------------------------
>
> (Updated Oct. 2, 2017, 3:14 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and James Peach.
>
>
> Bugs: MESOS-7828
> https://issues.apache.org/jira/browse/MESOS-7828
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test `ProtobufTest.ParseJSONUnrecognizedEnum`.
>
>
> Diffs
> -----
>
> 3rdparty/stout/tests/protobuf_tests.cpp 8877e8934e0f7875bfedcfa88b491ce4b13ca44f
> 3rdparty/stout/tests/protobuf_tests.proto d16726aa8060aea2b830040b20dbdd467c801483
>
>
> Diff: https://reviews.apache.org/r/61174/diff/5/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 61174: Added a test
`ProtobufTest.ParseJSONUnrecognizedEnum`.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61174/
-----------------------------------------------------------
(Updated Oct. 2, 2017, 11:14 p.m.)
Review request for mesos, Benjamin Mahler and James Peach.
Changes
-------
Addressed review comments.
Bugs: MESOS-7828
https://issues.apache.org/jira/browse/MESOS-7828
Repository: mesos
Description
-------
Added a test `ProtobufTest.ParseJSONUnrecognizedEnum`.
Diffs (updated)
-----
3rdparty/stout/tests/protobuf_tests.cpp 8877e8934e0f7875bfedcfa88b491ce4b13ca44f
3rdparty/stout/tests/protobuf_tests.proto d16726aa8060aea2b830040b20dbdd467c801483
Diff: https://reviews.apache.org/r/61174/diff/5/
Changes: https://reviews.apache.org/r/61174/diff/4-5/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 61174: Added a test
`ProtobufTest.ParseJSONUnrecognizedEnum`.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61174/#review186707
-----------------------------------------------------------
Fix it, then Ship it!
3rdparty/stout/tests/protobuf_tests.cpp
Lines 423-425 (patched)
<https://reviews.apache.org/r/61174/#comment263502>
Let's clarify that the field will be unset (similar to how this is handled by protobuf de-serialization).
- Benjamin Mahler
On Sept. 29, 2017, 8:47 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61174/
> -----------------------------------------------------------
>
> (Updated Sept. 29, 2017, 8:47 a.m.)
>
>
> Review request for mesos, Benjamin Mahler and James Peach.
>
>
> Bugs: MESOS-7828
> https://issues.apache.org/jira/browse/MESOS-7828
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test `ProtobufTest.ParseJSONUnrecognizedEnum`.
>
>
> Diffs
> -----
>
> 3rdparty/stout/tests/protobuf_tests.cpp 8877e8934e0f7875bfedcfa88b491ce4b13ca44f
> 3rdparty/stout/tests/protobuf_tests.proto d16726aa8060aea2b830040b20dbdd467c801483
>
>
> Diff: https://reviews.apache.org/r/61174/diff/4/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 61174: Added a test
`ProtobufTest.ParseJSONUnrecognizedEnum`.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61174/#review186742
-----------------------------------------------------------
Fix it, then Ship it!
3rdparty/stout/tests/protobuf_tests.cpp
Lines 430 (patched)
<https://reviews.apache.org/r/61174/#comment263541>
I think it is the same case, but could you add a case where the enum has an empty value?
```
"empty": ""
```
This ought to behave the same as the "XXX"
3rdparty/stout/tests/protobuf_tests.cpp
Lines 432 (patched)
<https://reviews.apache.org/r/61174/#comment263542>
Just a suggestion ... consider a separate patch to use raw string literals for all the JSON in this file so we can remove all the escaping.
- James Peach
On Sept. 29, 2017, 8:47 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61174/
> -----------------------------------------------------------
>
> (Updated Sept. 29, 2017, 8:47 a.m.)
>
>
> Review request for mesos, Benjamin Mahler and James Peach.
>
>
> Bugs: MESOS-7828
> https://issues.apache.org/jira/browse/MESOS-7828
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test `ProtobufTest.ParseJSONUnrecognizedEnum`.
>
>
> Diffs
> -----
>
> 3rdparty/stout/tests/protobuf_tests.cpp 8877e8934e0f7875bfedcfa88b491ce4b13ca44f
> 3rdparty/stout/tests/protobuf_tests.proto d16726aa8060aea2b830040b20dbdd467c801483
>
>
> Diff: https://reviews.apache.org/r/61174/diff/4/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 61174: Added a test
`ProtobufTest.ParseJSONUnrecognizedEnum`.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61174/#review186813
-----------------------------------------------------------
Patch looks great!
Reviews applied: [61109, 61174]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Sept. 29, 2017, 8:47 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61174/
> -----------------------------------------------------------
>
> (Updated Sept. 29, 2017, 8:47 a.m.)
>
>
> Review request for mesos, Benjamin Mahler and James Peach.
>
>
> Bugs: MESOS-7828
> https://issues.apache.org/jira/browse/MESOS-7828
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test `ProtobufTest.ParseJSONUnrecognizedEnum`.
>
>
> Diffs
> -----
>
> 3rdparty/stout/tests/protobuf_tests.cpp 8877e8934e0f7875bfedcfa88b491ce4b13ca44f
> 3rdparty/stout/tests/protobuf_tests.proto d16726aa8060aea2b830040b20dbdd467c801483
>
>
> Diff: https://reviews.apache.org/r/61174/diff/4/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 61174: Added a test
`ProtobufTest.ParseJSONUnrecognizedEnum`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61174/#review186659
-----------------------------------------------------------
PASS: Mesos patch 61174 was successfully built and tested.
Reviews applied: `['61109', '61174']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/61174
- Mesos Reviewbot Windows
On Sept. 29, 2017, 8:47 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61174/
> -----------------------------------------------------------
>
> (Updated Sept. 29, 2017, 8:47 a.m.)
>
>
> Review request for mesos, Benjamin Mahler and James Peach.
>
>
> Bugs: MESOS-7828
> https://issues.apache.org/jira/browse/MESOS-7828
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test `ProtobufTest.ParseJSONUnrecognizedEnum`.
>
>
> Diffs
> -----
>
> 3rdparty/stout/tests/protobuf_tests.cpp 8877e8934e0f7875bfedcfa88b491ce4b13ca44f
> 3rdparty/stout/tests/protobuf_tests.proto d16726aa8060aea2b830040b20dbdd467c801483
>
>
> Diff: https://reviews.apache.org/r/61174/diff/4/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>