You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2019/12/24 06:08:21 UTC
[GitHub] [rocketmq] RongtongJin commented on a change in pull request #1625:
[ISSUE #1639] use ipv4 first when choosing local IP
RongtongJin commented on a change in pull request #1625: [ISSUE #1639] use ipv4 first when choosing local IP
URL: https://github.com/apache/rocketmq/pull/1625#discussion_r361074386
##########
File path: common/src/main/java/org/apache/rocketmq/common/UtilAll.java
##########
@@ -547,8 +547,6 @@ public static String ipToIPv6Str(byte[] ip) {
if (ipV6Check(ipByte)) {
if (!isInternalV6IP(ip)) {
return ipByte;
- } else if (internalIP == null) {
Review comment:
Is it possible that there is only internal IPv6 address? If it exists, the IP address cannot be obtained.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services