You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/11/19 05:17:47 UTC
[GitHub] [incubator-superset] rusackas opened a new pull request #8600:
Filter edit with font awesome
rusackas opened a new pull request #8600: Filter edit with font awesome
URL: https://github.com/apache/incubator-superset/pull/8600
### CATEGORY
Choose one
- [ ] Bug Fix
- [ ] Enhancement (new features, refinement)
- [x] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
This is pretty minor, but just something I noticed while looking around. Since Superset uses FontAwesome, we can replace a custom component with custom SVG by using a simple FontAwesome image.
We should probably upgrade to FontAwesome 5 at some point... many more toys in that toybox!
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
### REVIEWERS
@graceguo-supercat / @mistercrunch
**Note:** This doesn't change any functionality, but as far as I can tell, that button doesn't have functionality in the first place, or at least nothing happens when I click it. Is it for future use, or am I missing something?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org