You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "rusackas (via GitHub)" <gi...@apache.org> on 2026/08/11 20:45:31 UTC

Re: [PR] fix(chart): dataset dropdown sorted by name [superset]

rusackas commented on PR #42475:
URL: https://github.com/apache/superset/pull/42475#issuecomment-5258652670

   Thanks @SkinnyPigeon! Good call reusing `propertyComparator` instead of hand-rolling it, keeps this consistent with how sorting works everywhere else in the app. Test fixture change addresses the earlier concern about it not actually discriminating sorted vs unsorted output. LGTM, approving.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org