You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/07/08 11:46:37 UTC

[GitHub] [arrow] lidavidm commented on a diff in pull request #13547: ARROW-17013: [CI][C++] Fix arrow build for Ubuntu CPP 22.04

lidavidm commented on code in PR #13547:
URL: https://github.com/apache/arrow/pull/13547#discussion_r916739963


##########
cpp/src/arrow/flight/sql/CMakeLists.txt:
##########
@@ -117,10 +117,4 @@ if(ARROW_BUILD_TESTS OR ARROW_BUILD_EXAMPLES)
   add_executable(flight-sql-test-app test_app_cli.cc)
   target_link_libraries(flight-sql-test-app PRIVATE ${ARROW_FLIGHT_SQL_TEST_LINK_LIBS}
                                                     ${GFLAGS_LIBRARIES})
-
-  if(ARROW_FLIGHT_TEST_LINKAGE STREQUAL "static" AND ARROW_BUILD_STATIC)
-    target_compile_definitions(flight_sql_test

Review Comment:
   Oops, my bad. We still need this block, though, I believe. Just replace `flight_sql_test` with `arrow-flight-sql-test`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org