[jira] [Comment Edited] (OFBIZ-12270) Add menu-container-style to calendar menu

["Nicolas Malin (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-12270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17376455#comment-17376455 ] 

Nicolas Malin edited comment on OFBIZ-12270 at 7/7/21, 9:59 AM:
----------------------------------------------------------------

From my part I analyse if the menu orientation match an existing menu on framework/common/widget/CommonMenus.xml
{code:java}
    <menu name="Calendar" extends="CommonTabBarMenu" extends-resource="component://common/widget/CommonMenus.xml">{code}
I didn't know if it's the good selection, just an example to explain.
 Thus when you create a theme it's easier to manage the style of menu present Common instead control each screen who can implement a css class


was (Author: soledad):
From my part I analyse if the menu orientation match an existing menu on framework/common/widget/CommonMenus.xml
{code:java}
    <menu name="Calendar" extends="CommonTabBarMenu" extends-resource="component://common/widget/CommonMenus.xml">{code}
I didn't know if it's the good selection, just to example to explain.
Thus when you create a theme it's easier to manage the style of menu present Common instead control each screen who can implement a css class

> Add menu-container-style to calendar menu
> -----------------------------------------
>
>                 Key: OFBIZ-12270
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-12270
>             Project: OFBiz
>          Issue Type: Sub-task
>    Affects Versions: Trunk
>            Reporter: Xin Wang
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: Upcoming Branch
>
>         Attachments: 0001-Add-menu-container-style-to-calendar-menu.patch, with-patch.png, without-patch.png
>
>
> Attached patch try to make calendar menu more appealing in Helveticus theme, Without this, menu items will be squeezed together.
>  
> See this for example: https://demo-trunk.ofbiz.apache.org/workeffort/control/calendar
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)