You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2021/03/03 11:11:39 UTC

[GitHub] [calcite] vlsi commented on pull request #2253: [CALCITE-4385] Extracts and eliminates/merges the condition that has common expressions (Jiatao Tao)

vlsi commented on pull request #2253:
URL: https://github.com/apache/calcite/pull/2253#issuecomment-789635686


   @Aaaaaaron ,
   1) I have no time here. No details, sorry.
   2) The comments (e.g. "code/performance", "checkDuplicateSubset") are helpful for other reviewers and committers so they don't accidentally commit the change without a proper review.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org