You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/08/21 16:26:59 UTC

[GitHub] [incubator-nuttx] masayuki2009 commented on a change in pull request #4388: esp32: Re-organize the interrupt handling process to correctly handle the SMP case

masayuki2009 commented on a change in pull request #4388:
URL: https://github.com/apache/incubator-nuttx/pull/4388#discussion_r693373955



##########
File path: arch/xtensa/src/esp32/esp32_serial.c
##########
@@ -1170,7 +1143,18 @@ static void dma_attach(uint8_t dma_chan)
       irq = ESP32_IRQ_UHCI1;
     }
 
-  esp32_attach_peripheral(cpu, periph, dma_cpuint);
+  /* Set up to receive peripheral interrupts on the current CPU */
+
+  cpu = up_cpu_index();
+  dma_cpuint esp32_setup_irq(cpu, periph, 1, ESP32_CPUINT_LEVEL);

Review comment:
       ```=``` is missing.
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org