[GitHub] [hbase] KanakaKumar commented on a change in pull request #2304: HBASE-24916: Region hole contains wrong regions pair when hole is cre…

[GitBox <gi...@apache.org>]

KanakaKumar commented on a change in pull request #2304:
URL: https://github.com/apache/hbase/pull/2304#discussion_r478925062



##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitorCluster.java
##########
@@ -231,4 +234,86 @@ public void testConsistency() throws IOException {
     row[row.length - 1] = (byte)(((int)row[row.length - 1]) + 1);
     return row;
   }
+
+  @Test
+  public void testHoles() throws IOException {
+    CatalogJanitor janitor = TEST_UTIL.getHBaseCluster().getMaster().getCatalogJanitor();
+
+    CatalogJanitor.Report report = janitor.getLastReport();
+    // Assert no problems.
+    assertTrue(report.isEmpty());
+    //Verify start and end region holes
+    verifyCornerHoles(janitor, T1);
+    //Verify start and end region holes
+    verifyCornerHoles(janitor, T2);
+    verifyMiddleHole(janitor);
+    //verify total number of holes, 2 in t1 and t2 each and one in t3
+    janitor.scan();
+    assertEquals(5, janitor.getLastReport().getHoles().size());

Review comment:
       Please run MetaFixer to verify is it processing these holes correctly.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org