You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/09/08 04:07:26 UTC
[GitHub] [hudi] alexeykudinkin opened a new pull request, #6631: [WIP] Fixing Hudi bundles requiring log4j2 on the classpath
alexeykudinkin opened a new pull request, #6631:
URL: https://github.com/apache/hudi/pull/6631
### Change Logs
In XXX, we've rebased Hudi to instead mostly rely on Log4j2 bridge and implementations (in tests).
However we actually missed the fact that `log4j-1.2-api` isn't actually an API module (as advertised) but rather a fully-fledged implementation bringing in requirement to provide Log4j2 impl jar on the classpath.
### Impact
Risk level: Medium
TBD Manual bundles compatibility verification.
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6631: [HUDI-4810] Fixing Hudi bundles requiring log4j2 on the classpath
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6631:
URL: https://github.com/apache/hudi/pull/6631#issuecomment-1240218501
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e8e8c4d8047b5985764f7534bd84e82763c3ad28",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e8e8c4d8047b5985764f7534bd84e82763c3ad28",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e8e8c4d8047b5985764f7534bd84e82763c3ad28 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yihua commented on a diff in pull request #6631: [HUDI-4810] Fixing Hudi bundles requiring log4j2 on the classpath
Posted by GitBox <gi...@apache.org>.
yihua commented on code in PR #6631:
URL: https://github.com/apache/hudi/pull/6631#discussion_r967550539
##########
hudi-client/hudi-flink-client/pom.xml:
##########
@@ -35,7 +35,21 @@
</properties>
<dependencies>
- <!-- Hudi -->
+ <!-- Logging -->
+ <dependency>
+ <groupId>org.apache.logging.log4j</groupId>
+ <artifactId>log4j-1.2-api</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.logging.log4j</groupId>
+ <artifactId>log4j-slf4j-impl</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>org.slf4j</groupId>
+ <artifactId>slf4j-api</artifactId>
+ </dependency>
Review Comment:
This will be addressed in [another PR](https://github.com/apache/hudi/pull/6550) to save CI resource.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yihua commented on a diff in pull request #6631: [HUDI-4810] Fixing Hudi bundles requiring log4j2 on the classpath
Posted by GitBox <gi...@apache.org>.
yihua commented on code in PR #6631:
URL: https://github.com/apache/hudi/pull/6631#discussion_r967538302
##########
hudi-aws/pom.xml:
##########
@@ -34,6 +34,12 @@
</properties>
<dependencies>
+ <!-- Logging -->
+ <dependency>
+ <groupId>org.apache.logging.log4j</groupId>
+ <artifactId>log4j-1.2-api</artifactId>
+ </dependency>
Review Comment:
Makes sense. I noticed that later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6631: [HUDI-4810] Fixing Hudi bundles requiring log4j2 on the classpath
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6631:
URL: https://github.com/apache/hudi/pull/6631#issuecomment-1241539499
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e8e8c4d8047b5985764f7534bd84e82763c3ad28",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11243",
"triggerID" : "e8e8c4d8047b5985764f7534bd84e82763c3ad28",
"triggerType" : "PUSH"
}, {
"hash" : "cf25a4e0d37980de4284afe841eced2f205b97a5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11262",
"triggerID" : "cf25a4e0d37980de4284afe841eced2f205b97a5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cf25a4e0d37980de4284afe841eced2f205b97a5 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11262)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] the-other-tim-brown commented on a diff in pull request #6631: [HUDI-4810] Fixing Hudi bundles requiring log4j2 on the classpath
Posted by GitBox <gi...@apache.org>.
the-other-tim-brown commented on code in PR #6631:
URL: https://github.com/apache/hudi/pull/6631#discussion_r966589943
##########
hudi-client/hudi-flink-client/pom.xml:
##########
@@ -35,7 +35,21 @@
</properties>
<dependencies>
- <!-- Hudi -->
+ <!-- Logging -->
+ <dependency>
Review Comment:
nitpick: indentation is off here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] alexeykudinkin commented on pull request #6631: [HUDI-4810] Fixing Hudi bundles requiring log4j2 on the classpath
Posted by GitBox <gi...@apache.org>.
alexeykudinkin commented on PR #6631:
URL: https://github.com/apache/hudi/pull/6631#issuecomment-1242420880
CI is green:
<img width="1509" alt="Screen Shot 2022-09-09 at 1 17 42 PM" src="https://user-images.githubusercontent.com/428277/189436191-1819ee55-b81b-414b-9136-1cd97199e908.png">
https://dev.azure.com/apache-hudi-ci-org/apache-hudi-ci/_build/results?buildId=11262&view=results
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yihua commented on a diff in pull request #6631: [HUDI-4810] Fixing Hudi bundles requiring log4j2 on the classpath
Posted by GitBox <gi...@apache.org>.
yihua commented on code in PR #6631:
URL: https://github.com/apache/hudi/pull/6631#discussion_r967525721
##########
hudi-cli/pom.xml:
##########
@@ -139,6 +139,12 @@
<version>${scala.version}</version>
</dependency>
+ <!-- Logging -->
+ <dependency>
+ <groupId>org.apache.logging.log4j</groupId>
+ <artifactId>log4j-1.2-api</artifactId>
+ </dependency>
Review Comment:
Similar here and in other modules.
##########
hudi-aws/pom.xml:
##########
@@ -34,6 +34,12 @@
</properties>
<dependencies>
+ <!-- Logging -->
+ <dependency>
+ <groupId>org.apache.logging.log4j</groupId>
+ <artifactId>log4j-1.2-api</artifactId>
+ </dependency>
Review Comment:
Should this already be included as a transitive dependency, introduced by `hudi-common` module?
##########
hudi-client/hudi-flink-client/pom.xml:
##########
@@ -35,7 +35,21 @@
</properties>
<dependencies>
- <!-- Hudi -->
+ <!-- Logging -->
+ <dependency>
+ <groupId>org.apache.logging.log4j</groupId>
+ <artifactId>log4j-1.2-api</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.logging.log4j</groupId>
+ <artifactId>log4j-slf4j-impl</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>org.slf4j</groupId>
+ <artifactId>slf4j-api</artifactId>
+ </dependency>
Review Comment:
nit: Indentation is off?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6631: [HUDI-4810] Fixing Hudi bundles requiring log4j2 on the classpath
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6631:
URL: https://github.com/apache/hudi/pull/6631#issuecomment-1240221583
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e8e8c4d8047b5985764f7534bd84e82763c3ad28",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11243",
"triggerID" : "e8e8c4d8047b5985764f7534bd84e82763c3ad28",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e8e8c4d8047b5985764f7534bd84e82763c3ad28 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11243)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6631: [HUDI-4810] Fixing Hudi bundles requiring log4j2 on the classpath
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6631:
URL: https://github.com/apache/hudi/pull/6631#issuecomment-1240550924
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e8e8c4d8047b5985764f7534bd84e82763c3ad28",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11243",
"triggerID" : "e8e8c4d8047b5985764f7534bd84e82763c3ad28",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e8e8c4d8047b5985764f7534bd84e82763c3ad28 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11243)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6631: [HUDI-4810] Fixing Hudi bundles requiring log4j2 on the classpath
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6631:
URL: https://github.com/apache/hudi/pull/6631#issuecomment-1241466870
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e8e8c4d8047b5985764f7534bd84e82763c3ad28",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11243",
"triggerID" : "e8e8c4d8047b5985764f7534bd84e82763c3ad28",
"triggerType" : "PUSH"
}, {
"hash" : "cf25a4e0d37980de4284afe841eced2f205b97a5",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "cf25a4e0d37980de4284afe841eced2f205b97a5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e8e8c4d8047b5985764f7534bd84e82763c3ad28 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11243)
* cf25a4e0d37980de4284afe841eced2f205b97a5 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6631: [HUDI-4810] Fixing Hudi bundles requiring log4j2 on the classpath
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6631:
URL: https://github.com/apache/hudi/pull/6631#issuecomment-1241469308
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e8e8c4d8047b5985764f7534bd84e82763c3ad28",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11243",
"triggerID" : "e8e8c4d8047b5985764f7534bd84e82763c3ad28",
"triggerType" : "PUSH"
}, {
"hash" : "cf25a4e0d37980de4284afe841eced2f205b97a5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11262",
"triggerID" : "cf25a4e0d37980de4284afe841eced2f205b97a5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e8e8c4d8047b5985764f7534bd84e82763c3ad28 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11243)
* cf25a4e0d37980de4284afe841eced2f205b97a5 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11262)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] alexeykudinkin commented on a diff in pull request #6631: [HUDI-4810] Fixing Hudi bundles requiring log4j2 on the classpath
Posted by GitBox <gi...@apache.org>.
alexeykudinkin commented on code in PR #6631:
URL: https://github.com/apache/hudi/pull/6631#discussion_r967528877
##########
hudi-aws/pom.xml:
##########
@@ -34,6 +34,12 @@
</properties>
<dependencies>
+ <!-- Logging -->
+ <dependency>
+ <groupId>org.apache.logging.log4j</groupId>
+ <artifactId>log4j-1.2-api</artifactId>
+ </dependency>
Review Comment:
"provided" deps are not included transitively
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yihua merged pull request #6631: [HUDI-4810] Fixing Hudi bundles requiring log4j2 on the classpath
Posted by GitBox <gi...@apache.org>.
yihua merged PR #6631:
URL: https://github.com/apache/hudi/pull/6631
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org