You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/04/23 04:25:02 UTC
[GitHub] [incubator-pinot] sunithabeeram commented on a change in pull
request #4152: Fix the issue where ZkCacheBaseDataAccessor.getChildren()
can return list with null znRecords
sunithabeeram commented on a change in pull request #4152: Fix the issue where ZkCacheBaseDataAccessor.getChildren() can return list with null znRecords
URL: https://github.com/apache/incubator-pinot/pull/4152#discussion_r277513858
##########
File path: pinot-common/src/main/java/org/apache/pinot/common/metadata/ZKMetadataProvider.java
##########
@@ -297,70 +297,88 @@ public static Schema getTableSchema(@Nonnull ZkHelixPropertyStore<ZNRecord> prop
*/
public static List<OfflineSegmentZKMetadata> getOfflineSegmentZKMetadataListForTable(
ZkHelixPropertyStore<ZNRecord> propertyStore, String tableName) {
Review comment:
Should the signature include @Nonnull for propertyStore?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org