Struts - latest build - possible change

[Kevin Duffey <kd...@buymedia.com>]

Hi,

Craig,

In the ActionServlet class, I recommend a "minor" change...


    protected boolean processValidate(ActionMapping mapping,
        ActionForm formInstance, HttpServletRequest request,
        HttpServletResponse response)
        throws IOException, ServletException {

	// Skip validation if it is not appropriate
	if (formInstance == null)
	    return (true);
	if (!(formInstance instanceof ValidatingActionForm))
	    return (true);
	if (mapping.getInputForm() == null)
	    return (true);

	// Perform the requested validation
	if (debug >= 1)
	    log(" Validating bean properties");
	String errors[] = ((ValidatingActionForm) formInstance).validate();
	if ((errors == null) || (errors.length == 0))
	    return (true);

	// Save our error messages and return to the input form
	String uri = mapping.getInputForm();
	if (debug >= 1)
	    log(" Form validation error: redirecting to: " + uri);
	request.setAttribute(Action.ERROR_KEY, errors);
	RequestDispatcher rd = getServletContext().getRequestDispatcher(uri);
	rd.forward(request, response);
	return (false);

    }


in this method, possibly add the ability to response.sendRedirect() to the
page, like you do in the process() call for ActionForward (true/false for
forward/redirect).


Yeah/Nay?