You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/11/15 05:56:41 UTC

[GitHub] [netbeans] KacerCZ opened a new pull request #2537: [NETBEANS-5029] PHP - generated methods are public by default

KacerCZ opened a new pull request #2537:
URL: https://github.com/apache/netbeans/pull/2537


   https://issues.apache.org/jira/browse/NETBEANS-5029
   
   Changes default value for generating public modifier of constructor/getters/setters to enabled.
   
   ![constructor-generator](https://user-images.githubusercontent.com/4249184/99178040-9d2e9300-270f-11eb-83b4-55a5428fd39c.png)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] tmysik commented on pull request #2537: [NETBEANS-5029] PHP - generated methods are public by default

Posted by GitBox <gi...@apache.org>.
tmysik commented on pull request #2537:
URL: https://github.com/apache/netbeans/pull/2537#issuecomment-731158416


   @KacerCZ 
   
   I see. Project settings seem fine to me. And those were just possible enhancements, as I wrote.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] tmysik commented on pull request #2537: [NETBEANS-5029] PHP - generated methods are public by default

Posted by GitBox <gi...@apache.org>.
tmysik commented on pull request #2537:
URL: https://github.com/apache/netbeans/pull/2537#issuecomment-731050319


   Looks good to me. Perhaps, as a possible enhancement, we could replace the given checkbox with a combo box (protected/public). And one more thing - it would be nice if the value could be remembered (in user properties) and restored whenever this dialog appears.
   
   Thanks!
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] junichi11 commented on pull request #2537: [NETBEANS-5029] PHP - generated methods are public by default

Posted by GitBox <gi...@apache.org>.
junichi11 commented on pull request #2537:
URL: https://github.com/apache/netbeans/pull/2537#issuecomment-730836706


   @tmysik Could you please merge this if it's OK with you?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] tmysik merged pull request #2537: [NETBEANS-5029] PHP - generated methods are public by default

Posted by GitBox <gi...@apache.org>.
tmysik merged pull request #2537:
URL: https://github.com/apache/netbeans/pull/2537


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] KacerCZ commented on pull request #2537: [NETBEANS-5029] PHP - generated methods are public by default

Posted by GitBox <gi...@apache.org>.
KacerCZ commented on pull request #2537:
URL: https://github.com/apache/netbeans/pull/2537#issuecomment-731142094


   @junichi11 @tmysik Thanks for review.
   
   Regarding protected/public selection - I needed protected getter only in rare occasions and it was always easier to change generated code than change setting in dialog and then to remember change it back.
   
   If I understand this code correctly, then setting is saved to project:
   https://github.com/apache/netbeans/blob/f986c03ac36c77c077165a4e0e3d7e4b680bc562/php/php.editor/src/org/netbeans/modules/php/editor/codegen/CGSGenerator.java#L414-L445


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists