You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/06/13 05:07:40 UTC
[GitHub] [incubator-mxnet] Kh4L opened a new pull request #18555: Remove check for subgraph with cycles
Kh4L opened a new pull request #18555:
URL: https://github.com/apache/incubator-mxnet/pull/18555
## Description ##
Partitioning a graph with potential subgraphs that have a cycle with the input or output fails instead of ignoring these subgraphs. For instance, Faster-RCNN (available in the GluonCV model zoo) optimization failed.
## Change ##
This PR simply removes the check that raise an exception if the subgraph candidate has a cycle, so LabelSubgraph can return false.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18555: Remove check for subgraph with cycles
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18555:
URL: https://github.com/apache/incubator-mxnet/pull/18555#issuecomment-643570911
Hey @Kh4L , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [sanity, edge, unix-cpu, unix-gpu, miscellaneous, windows-cpu, centos-cpu, website, windows-gpu, centos-gpu, clang]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18555: Remove check for subgraph with cycles
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18555:
URL: https://github.com/apache/incubator-mxnet/pull/18555#issuecomment-668321369
Jenkins CI successfully triggered : [centos-cpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18555: Remove check for subgraph with cycles
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18555:
URL: https://github.com/apache/incubator-mxnet/pull/18555#issuecomment-668274470
Jenkins CI successfully triggered : [unix-cpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18555: Remove check for subgraph with cycles
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18555:
URL: https://github.com/apache/incubator-mxnet/pull/18555#issuecomment-668318692
Jenkins CI successfully triggered : [clang]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] Kh4L commented on pull request #18555: Remove check for subgraph with cycles
Posted by GitBox <gi...@apache.org>.
Kh4L commented on pull request #18555:
URL: https://github.com/apache/incubator-mxnet/pull/18555#issuecomment-668274449
@mxnet-bot run ci [unix-cpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] samskalicky commented on a change in pull request #18555: Remove check for subgraph with cycles
Posted by GitBox <gi...@apache.org>.
samskalicky commented on a change in pull request #18555:
URL: https://github.com/apache/incubator-mxnet/pull/18555#discussion_r447447347
##########
File path: src/operator/subgraph/build_subgraph.cc
##########
@@ -306,14 +300,19 @@ void PreSelectSubgraphNodes(const nnvm::Graph& g, SubgraphSelectorV2Ptr subgraph
const std::vector<BiDirectedNodePtr>& simple_nodes,
std::vector<BiDirectedNode*>* subgraph_nodes) {
std::unordered_set<const BiDirectedNode*> excluded_nodes;
+ size_t n_excluded_nodes = 0;
const size_t max_num_retry = simple_nodes.size() * simple_nodes.size();
size_t count = 0;
bool success = false;
while (!success && count < max_num_retry) {
success = LabelSubgraph(g, subgraph_selector, label, snid, simple_nodes, subgraph_nodes,
&excluded_nodes);
if (!success) {
- CHECK(!excluded_nodes.empty());
+ if (excluded_nodes.size() == n_excluded_nodes) {
Review comment:
Do nodes have to be excluded in order to have a possible subgraph?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] Kh4L commented on pull request #18555: Remove check for subgraph with cycles
Posted by GitBox <gi...@apache.org>.
Kh4L commented on pull request #18555:
URL: https://github.com/apache/incubator-mxnet/pull/18555#issuecomment-668321349
@mxnet-bot run ci [centos-cpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ptrendx merged pull request #18555: Remove check for subgraph with cycles
Posted by GitBox <gi...@apache.org>.
ptrendx merged pull request #18555:
URL: https://github.com/apache/incubator-mxnet/pull/18555
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] Kh4L commented on pull request #18555: Remove check for subgraph with cycles
Posted by GitBox <gi...@apache.org>.
Kh4L commented on pull request #18555:
URL: https://github.com/apache/incubator-mxnet/pull/18555#issuecomment-668318658
@mxnet-bot run ci [clang]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org