You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "eugenegujing (via GitHub)" <gi...@apache.org> on 2026/07/13 22:19:14 UTC
[I] add unit test coverage for dashboard type-predicates [texera]
eugenegujing opened a new issue, #6400:
URL: https://github.com/apache/texera/issues/6400
### Task Summary
`frontend/src/app/dashboard/type/type-predicates.ts` exports the five type-guard functions (`isDashboardWorkflow`, `isDashboardProject`, `isDashboardFile`, `isDashboardDataset`, `isDashboardWorkflowComputingUnit`) that `DashboardEntry` uses to classify every dashboard and search-result item by structural checks — for example `isDashboardProject` requires a string `name` and the absence of a `workflow` field, so a misclassification would break how the dashboard renders an entry.
The file has no test coverage: no spec imports it or references any of the five functions, its only production consumer is `dashboard-entry.ts` (itself without a dedicated spec), and the only spec-side contact is `user-workflow.component.spec.ts` constructing workflow-entry fixtures, which incidentally runs `isDashboardWorkflow` on its happy path without asserting anything about classification — the other four predicates and every negative/exclusion branch never execute anywhere in the test tree.
### Task Type
- [ ] Refactor / Cleanup
- [ ] DevOps / Deployment / CI
- [x] Testing / QA
- [ ] Documentation
- [ ] Performance
- [ ] Other
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] add unit test coverage for dashboard type-predicates [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan closed issue #6400: add unit test coverage for dashboard type-predicates
URL: https://github.com/apache/texera/issues/6400
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] add unit test coverage for dashboard type-predicates [texera]
Posted by "eugenegujing (via GitHub)" <gi...@apache.org>.
eugenegujing commented on issue #6400:
URL: https://github.com/apache/texera/issues/6400#issuecomment-4963319393
/take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org