[GitHub] [orc] wgtmac commented on a diff in pull request #1596: ORC-1490: Fix bug in `getWriterVersion` due to unchecked `footer.hasWriter()`

["wgtmac (via GitHub)" <gi...@apache.org>]

wgtmac commented on code in PR #1596:
URL: https://github.com/apache/orc/pull/1596#discussion_r1303184871


##########
java/core/src/java/org/apache/orc/impl/OrcTail.java:
##########
@@ -31,6 +31,7 @@
 import java.nio.ByteBuffer;
 import java.util.ArrayList;
 import java.util.List;
+import static org.apache.orc.OrcFile.WriterImplementation.UNKNOWN;

Review Comment:
   nit: should we avoid this static import?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org