You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/02/08 12:44:28 UTC

[GitHub] [hudi] nsivabalan commented on a change in pull request #2520: [HUDI-1446] Support skip bootstrapIndex's init in abstract fs view init

nsivabalan commented on a change in pull request #2520:
URL: https://github.com/apache/hudi/pull/2520#discussion_r572017833



##########
File path: hudi-common/src/main/java/org/apache/hudi/common/bootstrap/index/DefaultBootstrapIndex.java
##########
@@ -0,0 +1,61 @@
+package org.apache.hudi.common.bootstrap.index;
+
+import org.apache.hudi.common.model.BootstrapFileMapping;
+import org.apache.hudi.common.table.HoodieTableMetaClient;
+
+import java.util.*;
+
+public class DefaultBootstrapIndex extends BootstrapIndex {

Review comment:
       can you please add some java docs as to why we have this bootstrap index. 
   @Xoln : Also, can you help me understand even w/ this new bootstrap index, users needs to specify the bootstrap index class config right? (hoodie.bootstrap.index.class). Why can't we make this class default value for this config. So, even if users don't set them, we will default to this. Guess that was your intention if I am not wrong. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org