You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@celix.apache.org by GitBox <gi...@apache.org> on 2023/01/09 17:42:49 UTC
[GitHub] [celix] pnoltes opened a new pull request, #467: Fix several null pointer dereferences and uninitialized variables issues
pnoltes opened a new pull request, #467:
URL: https://github.com/apache/celix/pull/467
These issue were found in the latest coverity scan.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [celix] rlenferink commented on a diff in pull request #467: Fix several null pointer dereferences and uninitialized variables issues
Posted by GitBox <gi...@apache.org>.
rlenferink commented on code in PR #467:
URL: https://github.com/apache/celix/pull/467#discussion_r1064990222
##########
bundles/pubsub/pubsub_protocol/pubsub_protocol_wire_v1/gtest/src/PS_WP_tests.cc:
##########
@@ -234,6 +234,7 @@ TEST_F(WireProtocolV1Test, WireProtocolV1Test_DecodeMetadata_Test) { // NOLINT(c
memcpy(exp + 4, "1:a,1:b,", 8);
pubsub_protocol_message_t message;
+ message.header.convertEndianess = false;
Review Comment:
Endianess => Endianness
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [celix] pnoltes commented on a diff in pull request #467: Fix several null pointer dereferences and uninitialized variables issues
Posted by GitBox <gi...@apache.org>.
pnoltes commented on code in PR #467:
URL: https://github.com/apache/celix/pull/467#discussion_r1067947676
##########
bundles/pubsub/pubsub_protocol/pubsub_protocol_wire_v1/gtest/src/PS_WP_tests.cc:
##########
@@ -234,6 +234,7 @@ TEST_F(WireProtocolV1Test, WireProtocolV1Test_DecodeMetadata_Test) { // NOLINT(c
memcpy(exp + 4, "1:a,1:b,", 8);
pubsub_protocol_message_t message;
+ message.header.convertEndianess = false;
Review Comment:
I will correct this as bug fix, but note that this does change the interfaces (SPI) header.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [celix] codecov-commenter commented on pull request #467: Fix several null pointer dereferences and uninitialized variables issues
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #467:
URL: https://github.com/apache/celix/pull/467#issuecomment-1376024798
# [Codecov](https://codecov.io/gh/apache/celix/pull/467?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#467](https://codecov.io/gh/apache/celix/pull/467?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c525121) into [master](https://codecov.io/gh/apache/celix/commit/2ccce27a7cfd6d1dec3ab1537271dc31d574d8ec?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2ccce27) will **increase** coverage by `0.05%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #467 +/- ##
==========================================
+ Coverage 74.29% 74.34% +0.05%
==========================================
Files 199 199
Lines 29600 29600
==========================================
+ Hits 21990 22006 +16
+ Misses 7610 7594 -16
```
| [Impacted Files](https://codecov.io/gh/apache/celix/pull/467?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...sub\_protocol\_lib/src/pubsub\_wire\_protocol\_common.c](https://codecov.io/gh/apache/celix/pull/467?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX3Byb3RvY29sL3B1YnN1Yl9wcm90b2NvbF9saWIvc3JjL3B1YnN1Yl93aXJlX3Byb3RvY29sX2NvbW1vbi5j) | `81.37% <100.00%> (ø)` | |
| [libs/utils/src/hash\_map.c](https://codecov.io/gh/apache/celix/pull/467?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlicy91dGlscy9zcmMvaGFzaF9tYXAuYw==) | `93.25% <0.00%> (-1.13%)` | :arrow_down: |
| [...les/pubsub/pubsub\_admin\_zmq/src/pubsub\_zmq\_admin.c](https://codecov.io/gh/apache/celix/pull/467?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3ptcS9zcmMvcHVic3ViX3ptcV9hZG1pbi5j) | `53.42% <0.00%> (+0.45%)` | :arrow_up: |
| [...sub\_topology\_manager/src/pubsub\_topology\_manager.c](https://codecov.io/gh/apache/celix/pull/467?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX3RvcG9sb2d5X21hbmFnZXIvc3JjL3B1YnN1Yl90b3BvbG9neV9tYW5hZ2VyLmM=) | `54.38% <0.00%> (+1.99%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [celix] PengZheng merged pull request #467: Fix several null pointer dereferences and uninitialized variables issues
Posted by GitBox <gi...@apache.org>.
PengZheng merged PR #467:
URL: https://github.com/apache/celix/pull/467
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org